Bug 1000058 - broken dependency after osm-gps-map update to 1.0
Summary: broken dependency after osm-gps-map update to 1.0
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-osmgpsmap
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeffrey C. Ollie
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-22 15:01 UTC by Jiri Kastner
Modified: 2013-08-28 19:53 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-28 19:53:39 UTC
Type: Bug


Attachments (Terms of Use)
Mock log (5.30 KB, text/plain)
2013-08-22 15:08 UTC, Gwyn Ciesla
no flags Details

Description Jiri Kastner 2013-08-22 15:01:02 UTC
Description of problem:
broken dependency after osm-gps-map update to 1.0 in rawhide

Version-Release number of selected component (if applicable):
0.7.3

How reproducible:
in rawhide

Steps to Reproduce:
1. yum install gramps --releasever=rawhide
2. check output
 

Actual results:
fails as python-osmgpsmap depends on 0.7.3 version of osm-gps-map

Expected results:
python-osmgpsmap updated to release compatible with 1.0 so gramps dependencies will not be broken

Additional info:

Comment 1 Richard Shaw 2013-08-22 15:06:09 UTC
Just an FYI...

The python-osmgpsmap package needs to be obsoleted. The newer version of osm-gps-map no longer provides the python bindings, they are provided by gobject introspection (google that! I was confused on how that worked until I did.) 

Long story short, the gramps package needs to be updated to use the new gobject python bindings instead of the old package.

I'm working on it on my own but I'm not the maintainer.

Comment 2 Gwyn Ciesla 2013-08-22 15:08:10 UTC
Created attachment 789256 [details]
Mock log

Bump and rebuild fails.

Comment 3 Richard Shaw 2013-08-22 15:25:39 UTC
Jon,

I'm not seeing that error on my build so perhaps I've gotten the BR's figured out.

I'm not seeing any errors during use with my package and under the "Help" there is a plugin/module tool and everything say "OK", however I still haven't gotten the maps to actually show me anything.

That being said, I never got it to work before so that's not necessarily a new bug.

https://dl.dropboxusercontent.com/u/34775202/gramps.spec

Comment 4 Gwyn Ciesla 2013-08-22 15:33:49 UTC
To clarify, that was a log from a python-osmgpsmap rebuild, not gramps.

Comment 5 Richard Shaw 2013-08-22 15:38:05 UTC
Oops. Bad assumption on my part. I'm not surprised it failed since the new osm-gps-map package doesn't support it.

Comment 6 Gwyn Ciesla 2013-08-22 15:42:27 UTC
So maybe python-osmgpsmap just needs to be retired?  Not sure, not that familiar.  If the one(?) remaining package that needs it really can't live without it maybe we need compat-osm-gps-map07. . .

Comment 7 Richard Shaw 2013-08-22 16:10:03 UTC
Yes, it needs to be retired... As far as gramps goes though, my understanding is that the 4.X version has been updated to utilize the new gobject python bindings but it's not clear to me how to ensure that it actually is.

Looking at existing packages it appears that they provide a separate gobject sub-package, but osm-gps-map currently does not. I don't know if that means it's being provided in the main package or not at all.

I'm going to play around with osm-gps-map and see what I can find out.

Comment 8 Jeffrey C. Ollie 2013-08-22 16:25:59 UTC
(In reply to Jon Ciesla from comment #6)
> So maybe python-osmgpsmap just needs to be retired?  Not sure, not that
> familiar.  If the one(?) remaining package that needs it really can't live
> without it maybe we need compat-osm-gps-map07. . .

It seems rather a waste to have a compatibility package for one package.  From what I see in the Gramps SVN it's been ported to use the new introspection bindings.

Comment 9 Richard Shaw 2013-08-22 16:38:37 UTC
Looking at the rawhide build log for osm-gps-map we should be OK:
checking for gobject-introspection... yes
...
Introspection support : yes
...

What's interesting is that most packages that provide a gobject subpackage either provide a library <pkgname>-gobject.so or <pkgname>-gi.so or something to that effect. osm-gps-map only provides two files that look promising:

/usr/lib64/girepository-1.0/OsmGpsMap-1.0.typelib
/usr/share/gir-1.0/OsmGpsMap-1.0.gir

but neither are traditional .so libraries...

Comment 10 Richard Shaw 2013-08-22 18:00:36 UTC
Ok, apparently the .so libraries are not required, from what I can tell the typelib file is enough.

I was able to build and install osm-gps-map in mock and found that I also needed pyobject3 in order to successfully import the module manually (provides the gi module):

from gi.repository import OsmGpsMap

I also updated the osm-gps-map SRPM to put the typelib file in a -gobject subpackage to be consistent with other packages as there currently doesn't seem to be any guidelines in this area.

Since the two maintainers of osm-gps-map are on this BZ, could one of you review my updates and commit it?

https://dl.dropboxusercontent.com/u/34775202/osm-gps-map-1.0.1-3.fc18.src.rpm

After that, gramps will need a "Requires: osm-gps-map-gobject" added. Probably wouldn't hurt to require the base package as well although the gobject one will pull it in anyway.

Comment 11 Jeffrey C. Ollie 2013-08-22 19:00:02 UTC
(In reply to Richard Shaw from comment #10)
>
> Since the two maintainers of osm-gps-map are on this BZ, could one of you
> review my updates and commit it?

Can you post your changes as a diff?  It makes things easier to review.

Comment 13 Jeffrey C. Ollie 2013-08-22 19:54:16 UTC
I like the idea of a gobject introspection subpackage, but I'm not sure that we want to make it python-specific, because gobject introspection is language-neutral.  Instead the pygobject3 requirement should be added to gramps.

Comment 14 Gwyn Ciesla 2013-08-22 20:15:11 UTC
Agreed.  I'll do that once the gobject subpackage is built.

Comment 15 Richard Shaw 2013-08-22 20:52:51 UTC
Do you want me to update the spec or do you guys have it from here?

Comment 16 Jeffrey C. Ollie 2013-08-23 02:00:56 UTC
Richard, if you have access why don't you go ahead and do the update.

Comment 17 Jiri Kastner 2013-08-23 08:54:46 UTC
(In reply to Richard Shaw from comment #15)
> Do you want me to update the spec or do you guys have it from here?

what about to remove "--disable-introspection" in %configure (just for sure) :)

Comment 18 Jiri Kastner 2013-08-23 12:41:54 UTC
i modified it:
http://ur1.ca/f6e36

and tested with gramps-4.0.1-5 installed by force

Comment 19 Jiri Kastner 2013-08-23 12:47:26 UTC
i placed changes to master and launched build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=5845591

Comment 20 Richard Shaw 2013-08-23 13:15:25 UTC
I'm not currently a co-maintainer to either gramps or osm-gps-map...

Looks like Jiri took care of osm-gps-map. Can someone take care of gramps? Otherwise I will go ahead and request access.

Comment 21 Gwyn Ciesla 2013-08-23 13:17:24 UTC
Excellent, thanks!  I've kicked of a build of gramps using it and dropping this python-osmgspmap update.

Comment 22 Richard Shaw 2013-08-23 13:19:18 UTC
Just checking... Did you add osm-gps-map-gobject and pyobject3 as requirements?

Comment 23 Richard Shaw 2013-08-23 13:20:29 UTC
Or did you use my spec? Sorry, I'm trying to cut back on my coffee intake and apparently there are side effects :)

Comment 24 Jiri Kastner 2013-08-23 13:27:34 UTC
(In reply to Richard Shaw from comment #20)
> I'm not currently a co-maintainer to either gramps or osm-gps-map...
> 
> Looks like Jiri took care of osm-gps-map. Can someone take care of gramps?
> Otherwise I will go ahead and request access.

i can take as i play with webapp part :)

Comment 25 Gwyn Ciesla 2013-08-23 13:28:51 UTC
I added both osm-gps-map-gobject and pygobject3, yes. :)

Comment 26 Jiri Kastner 2013-08-26 14:49:05 UTC
can we python-osmgpsmap obsolete in rawhide and fc20?

Comment 27 Richard Shaw 2013-08-26 14:52:43 UTC
I don't think we have a choice, the package is useless with the 1.X release of osm-gps-map. 

https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life

We'll need an Obsoletes: / Provides: for osm-gps-map-gobject, correct?

Comment 28 Jiri Kastner 2013-08-28 09:07:57 UTC
(In reply to Richard Shaw from comment #27)
> I don't think we have a choice, the package is useless with the 1.X release
> of osm-gps-map. 
> 
> https://fedoraproject.org/wiki/How_to_remove_a_package_at_end_of_life
> 
> We'll need an Obsoletes: / Provides: for osm-gps-map-gobject, correct?

i did it, but still i'm receiving python-osmgpsmap dep mails

@jeffrey - can you, please run:
 fedpkg retire 'obsoleted by osm-gps-map-gobject'

Comment 29 Jeffrey C. Ollie 2013-08-28 19:53:39 UTC
OK, it's retired in f20+


Note You need to log in before you can comment on or make changes to this bug.