Bug 1000430 - konkretcmpi: __KReturn2 function should have format string annotation
Summary: konkretcmpi: __KReturn2 function should have format string annotation
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: konkretcmpi
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Radek Novacek
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks: 999043
TreeView+ depends on / blocked
 
Reported: 2013-08-23 12:42 UTC by Florian Weimer
Modified: 2016-12-01 00:31 UTC (History)
2 users (show)

Fixed In Version: konkretcmpi-0.9.1-3.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-11 18:09:18 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Florian Weimer 2013-08-23 12:42:17 UTC 
__KReturn2 in konkret/konkret.h lacks a printf format string attribute.  If you add that, GCC will check for mismatches at compile time:

http://docs.fedoraproject.org/en-US/Fedora_Security_Team//html/Defensive_Coding/sect-Defensive_Coding-C-Libc-vsnprintf.html

Checking the return value of vasprintf in the implementation might be a good idea as well.
Comment 2 Radek Novacek 2013-08-26 13:29:53 UTC 
Fixed upstream and in the konkretcmpi-0.9.1-3.el7. Thanks for the report.
Note You need to log in before you can comment on or make changes to this bug.