Created attachment 790558[details]
addingProp
Description of problem:
[rhevm] Backend - Webadmin - Cluster Properties-> Cluster Policy dialog box - Disable "+" when no more keys are available
Version-Release number of selected component (if applicable):
3.3/is11
How reproducible:
always
Steps to Reproduce:
1.create new DC & Cluster
2.Edit Cluster -> Cluster Policy -> change policy to other then "None"
3.Press the "+" to add more keys
Actual results:
Adds a line with value "No Available Keys" , and it is not saved when pressing OK
Expected results:
should disable the Button, along side with "-" when there are no
more keys available.
Additional info:
Should disabled the "-" button, when there are no
more lines to remove (today the "-" button is enabled in this case, but does nothing).
The only time the "-" button should be greyed out (except when there are no options) is when there is only one combo box and it contains "please select a key". This is of very limited value to the user. Handling the change of selection would introduce some unpleasant code.
There is a patch handling all other aspects of the bug, I would recommend accepting it.
Please confirm that this is acceptable by you.
(In reply to Noam Slomianko from comment #4)
> The only time the "-" button should be greyed out (except when there are no
> options) is when there is only one combo box and it contains "please select
> a key". This is of very limited value to the user. Handling the change of
> selection would introduce some unpleasant code.
> There is a patch handling all other aspects of the bug, I would recommend
> accepting it.
>
> Please confirm that this is acceptable by you.
sure, no problem (at least for 3.3).
Created attachment 790558 [details] addingProp Description of problem: [rhevm] Backend - Webadmin - Cluster Properties-> Cluster Policy dialog box - Disable "+" when no more keys are available Version-Release number of selected component (if applicable): 3.3/is11 How reproducible: always Steps to Reproduce: 1.create new DC & Cluster 2.Edit Cluster -> Cluster Policy -> change policy to other then "None" 3.Press the "+" to add more keys Actual results: Adds a line with value "No Available Keys" , and it is not saved when pressing OK Expected results: should disable the Button, along side with "-" when there are no more keys available. Additional info: Should disabled the "-" button, when there are no more lines to remove (today the "-" button is enabled in this case, but does nothing).