Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-text/rubygem-text.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-text/rubygem-text-1.2.3-1.fc.src.rpm Description: A collection of text algorithms: Levenshtein, Soundex, Metaphone, Double Metaphone, Figlet, Porter Stemming Fedora Account System Username: mtasaka
Taking
*I* would include in -doc: %{gem_instdir}/Rakefile %{gem_instdir}/test/ Can you please include https://raw.github.com/threedaymonk/text/master/COPYING.txt as SOURCE1? Otherwise it looks good.
Thank you for initial comments: (In reply to Miroslav Suchý from comment #2) > *I* would include in -doc: > %{gem_instdir}/Rakefile > %{gem_instdir}/test/ - For now I decided not to include this. > Can you please include > https://raw.github.com/threedaymonk/text/master/COPYING.txt > as SOURCE1? - Added this (note that in Source0 I renamed this so as not to make files' names duplicate when multiple srpm are expanded) > Otherwise it looks good. http://mtasaka.fedorapeople.org/Review_request/rubygem-text/rubygem-text.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-text/rubygem-text-1.2.3-2.fc.src.rpm * Fri Aug 30 2013 Mamoru TASAKA <mtasaka> - 1.2.3-2 - Include license text
APPROVED
Thank you! New Package SCM Request ======================= Package Name: rubygem-text Short Description: Collection of text algorithms Owners: mtasaka Branches: f18 f19 f20 InitialCC:
Git done (by process-git-requests).
Ping? Can we close this bug now? I see that you submited it to current Fedora: https://admin.fedoraproject.org/updates/FEDORA-2013-16543/rubygem-text-1.2.3-2.fc20 It is good habit to put in that form number of this BZ and bodhi will then automatically switch this BZ to ON_QA and Close it as the package hit stable. Also please add you package to: https://fedoraproject.org/wiki/Upstream_release_monitoring#Q_-_W so you are notified when new version is released.
Closing. Thank you for review. I am using my own check script for upstream monitoring.
(By the way, adding bugzilla number to bodhi adds the comment which tells that if any issues are found on the submitted packages, the issue should be reported on _this_ ticket, which is not proper. The issue should be reported should be reported against newly created component.)