Bug 1002269 - Newlines in client results between lines are reduced to a single newline
Summary: Newlines in client results between lines are reduced to a single newline
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Jessica Forrester
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-08-28 18:48 UTC by Clayton Coleman
Modified: 2015-05-15 01:23 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-19 16:46:17 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Clayton Coleman 2013-08-28 18:48:47 UTC
When adding a db:

--------
MySQL 5.1 database added.  Please make note of these credentials:
       Root User: adminBpclg5V
   Root Password: Qyrs7zmRAMjt
   Database Name: phps
Connection URL: mysql://$OPENSHIFT_MYSQL_DB_HOST:$OPENSHIFT_MYSQL_DB_PORT/
You can manage your new MySQL database by also embedding phpmyadmin-3.
The phpmyadmin username and password will be the same as the MySQL credentials above.
---------

It should be:
--------
MySQL 5.1 database added.  Please make note of these credentials:

       Root User: adminBpclg5V
   Root Password: Qyrs7zmRAMjt
   Database Name: phps

Connection URL: mysql://$OPENSHIFT_MYSQL_DB_HOST:$OPENSHIFT_MYSQL_DB_PORT/

You can manage your new MySQL database by also embedding phpmyadmin-3.
The phpmyadmin username and password will be the same as the MySQL credentials above.
--------

The REST API should be returning the individual newlines, and the clients should respect them (at least doubled newlines).  We can potentially trim >2 sequential.  We should trim trailing and leading newlines.  CLI and Website need to be showing the same thing.

Comment 1 Jessica Forrester 2013-08-30 17:49:39 UTC
Fixed in https://github.com/openshift/origin-server/pull/3527/files
and in https://github.com/openshift/rhc/pull/452

It was displaying incorrectly in both rhc and in the console.

Comment 2 openshift-github-bot 2013-08-31 02:32:37 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/fa36295b482e162a1e39d14f3a5f25999740e657
Bug 1002269 - empty client messages are dropped, should be new line

Comment 3 openshift-github-bot 2013-08-31 02:32:38 UTC
Commit pushed to master at https://github.com/openshift/rhc

https://github.com/openshift/rhc/commit/5479b61536ba922802e6edee716d40eb2b69a5a4
Bug 1002269 - trim leading newlines and trailing whitespace in client
messages

Comment 4 Yujie Zhang 2013-09-02 03:15:52 UTC
Tested on devenv_3734 from website and rhc client, the empty client messages have been correctted, so verify this bug, thanks.


Note You need to log in before you can comment on or make changes to this bug.