Red Hat Bugzilla – Bug 1002587
Cloning workspaces does not update reference properties
Last modified: 2016-02-10 03:57:15 EST
When cloning a source workspace into a target workspace, the nodes from the target workspace should have their reference properties updated to point towards the nodes from the target workspace.
At the moment this is not happening, causing a potential ReferentialIntegrityException.
Horia Chiorean <email@example.com> made a comment on jira MODE-2012
Attached a PR which fixes the cloning of reference properties across workspaces.
This PR contains the test case from https://github.com/ModeShape/modeshape/pull/922.
Randall Hauch <firstname.lastname@example.org> made a comment on jira MODE-2012
Merged [~hchiorean]'s latest pull-request, which fixes the underlying problem and adds several new smaller test cases to verify the functionality.
Much thanks to [~kbachl] and [~hchiorean] for all their hard work on this!
K. Bachl <email@example.com> made a comment on jira MODE-2012
Ok, I gave the fix a quick testdrive and so far all seems very very nice. I don't have anymore the referential exceptions, and the content from workspace A in clone B and C doesnt show up anymore. Beside, I now get the same size workspace.xml file when I import + export the content afterwards. I also noticed that the cachestore-datafiles doesnt seem to grow that fast anymore now. After some import/ export + cloning the current berkeley DB solution I use ends up using about 27,3 MB space what is about to expect as a workspace.xml of 1 workspace has about 8.3 MB, so it's a reasonable size (external files are only 725KB as I mostly have small bits in the workspace);
So far: Thank you for the awesome job at fixing this so fast (I've seen the pull-request: thumbs up on you Horia!).
I'm really looking forward to ModeShape 3.5 now!
Randall Hauch <firstname.lastname@example.org> updated the status of jira MODE-2012 to Closed
Fixed before GA - setting to requires_doc_text- accordingly