Description of problem: Admin console suggestions suggest adding nodes when gears capacity is below threshold, this is expected. But when there is node not in district, it show adding nodes to district NONE ( as below ), which is impossible. Add 7 nodes to district (NONE), which according to an active gear percent of 50% has room for 64 more nodes. oo-admin-ctl-district -c add-node -n '(NONE)' -i <server_identity> Version-Release number of selected component (if applicable): fork_ami_origin_ui_58_817 How reproducible: always Steps to Reproduce: 1.create a district. 2.add some nodes to the district while leave some nodes not in any district. 3.change config to make gears capacity less than threshold. 4.check the suggestions in admin console Actual results: Add capacity for small gear profile Gear profile small has capacity for 180 active gears, which is below the threshold of 1500. Create 15 nodes with profile small to increase the active gear capacity. This suggestion is based on: 1320 gears needed to both reach the threshold and meet the configured GEAR_UP_SIZE of this profile. The estimated maximum active gears of 90 for nodes in this profile. Add 8 nodes to district district11, which according to an active gear percent of 50% has room for 64 more nodes. oo-admin-ctl-district -c add-node -n 'district11' -i <server_identity> Add 7 nodes to district (NONE), which according to an active gear percent of 50% has room for 64 more nodes. oo-admin-ctl-district -c add-node -n '(NONE)' -i <server_identity> Add capacity for medium gear profile Gear profile medium has capacity for 40 active gears, which is below the threshold of 1000. Create 24 nodes with profile medium to increase the active gear capacity. This suggestion is based on: 960 gears needed to both reach the threshold and meet the configured GEAR_UP_SIZE of this profile. The estimated maximum active gears of 40 for nodes in this profile. Add 12 nodes to district disctrict44, which according to an active gear percent of 50% has room for 149 more nodes. oo-admin-ctl-district -c add-node -n 'disctrict44' -i <server_identity> Add 12 nodes to district (NONE), which according to an active gear percent of 50% has room for 149 more nodes. oo-admin-ctl-district -c add-node -n '(NONE)' -i <server_identity> # oo-admin-ctl-district -c add-node -n '(NONE)' -i ip-10-147-192-5 District '(NONE)' not found. Expected results: Adding nodes to district (NONE) should -not- be there. Additional info: https://broker/admin-console/suggestions
Meant to add a test for that... good catch, thanks.
Should be fixed with fork_ami_origin_ui_58_818
Tested this bug on fork_ami_origin_ui_58_818,it has been fixed. Steps to Reproduce: 1.create a district. 2.add some nodes to the district while leave some nodes not in any district. 3.change config to make gears capacity less than threshold. 4.check the suggestions in admin console no 'None' district shown in the admin-console-->suggestions
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/d893a1b69cfbb2f21846d2c270bdf35e3020b9d0 <admin suggestions> fix bug 1004157 https://bugzilla.redhat.com/show_bug.cgi?id=1004157 Admin console suggestions suggest adding nodes to district NONE which is impossible