Bug 1004173 - SRT does not display data for min and max metrics
Summary: SRT does not display data for min and max metrics
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Fuse Service Works 6
Classification: JBoss
Component: RT Governance
Version: 6.0.0 GA
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ER3
: ---
Assignee: Gary Brown
QA Contact: Jiri Sedlacek
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-04 06:58 UTC by Jiri Pechanec
Modified: 2015-08-02 23:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot (42.44 KB, image/png)
2013-09-04 06:59 UTC, Jiri Pechanec
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RTGOV-268 0 Major Closed Service response time aggregation not performed correctly for min/max values 2014-07-02 09:19:28 UTC

Description Jiri Pechanec 2013-09-04 06:58:14 UTC
See in attached screenshot - a service is called three times, there are different values for min, max and avg in active collection but the chart lines are same for all three metrics.

Comment 1 Jiri Pechanec 2013-09-04 06:59:07 UTC
Created attachment 793505 [details]
Screenshot

Notice the metrics in service overview and no difference in SRT gadget

Comment 2 Jiri Pechanec 2013-09-04 07:19:55 UTC
It seems that the issue is in active collection. If I execute the query manually then I get something like this
{
    "interface":"org.jboss.soa.qa.rtgsrt.SRTService",
    "timestamp":1378278790293,
    "min":1024,
    "max":1024,
    "serviceType":"{
    urn:switchyard-soa:rtgov_srt:0.1.0
}SRTTest/SRTService",
    "operation":"twoWay",
    "fault":null,
    "average":1024,
    "requestId":null,
    "responseId":null,
    "context":[],
    "properties":{
    
}

Comment 3 Jiri Pechanec 2013-09-04 08:37:01 UTC
AggregateServiceResponseTime.mvel uses only getAverage() calls never getMin() or getMax() - is it correct?

Comment 4 Gary Brown 2013-09-04 09:01:09 UTC
This is probably where the issue is - it averages based on the average value of each response time, setting the min/max values of those averages, rather doing an average calc for min, avg and max separately.

Comment 5 Gary Brown 2013-09-06 15:48:38 UTC
Have applied a change to the mvel script (https://github.com/Governance/rtgov/commit/9c547e723ff0608835c9992dcab3bf956f7d8a9e) - could you try this out, as not sure whether this is related to the issue you are seeing.

If not, then can you provide more information to help reproduce the problem scenario.

Comment 6 Jiri Pechanec 2013-09-09 13:53:57 UTC
It works as expected, good job

Comment 7 Jiri Pechanec 2013-09-24 10:20:06 UTC
Verified in ER3

Comment 11 JBoss JIRA Server 2014-07-02 09:19:28 UTC
Gary Brown <gary> updated the status of jira RTGOV-268 to Closed


Note You need to log in before you can comment on or make changes to this bug.