Red Hat Bugzilla – Bug 1004671
[fork][origin_ui_58] The count of left node is incorrect for suggestions when we have multi districts
Last modified: 2015-05-14 21:23:46 EDT
Description of problem:
If node_needed > suggest_node_per_distrct,then need to suggestions to add nodes to district, like this suggestion:"Add 4 nodes to district dist1, which according to an active gear percent of 10% has room for 22 more nodes." here 22 is incorrect, It should be the count of the left nodes of every district, not district*count - node_exist
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. create four small districts and add two nodes to one district(dist1)
2. set "GEAR_EXPECTED_ACTIVE_PERCENT=10" and "GEAR_UP_THRESHOLD=1000, small: 1980, large: 750
3.login on admin-console
suggestion:"Add 4 nodes to district dist1, which according to an active gear percent of 10% has room for 22 more nodes.
suggestion:"Add 4 nodes to district dist1, which according to an active gear percent of 10% has room for 4 more nodes.
Awesome catch. You are really paying close attention.
I think that number is meant to be the total that can be created in all districts, so it's being misrepresented. But it needs to be fixed regardless.
Should be fixed in fork_ami origin_ui_81 #824
Tested this bug on fork_ami origin_ui_81_825
Add 3 nodes to district d1, which according to an active gear percent of 5% has room for 3 more nodes.
oo-admin-ctl-district -c add-node -n 'd1' -i <server_identity>
Add 3 nodes to district d2, which according to an active gear percent of 5% has room for 3 more nodes.
oo-admin-ctl-district -c add-node -n 'd2' -i <server_identity>
Commit pushed to master at https://github.com/openshift/origin-server
<admin suggestions> fix bug 1004671
The count of nodes left is incorrect for suggestions when we have
The total nodes that could be created in all existing districts was
given, rather than how many could be created in a particular district.
Should correctly show per-district space for nodes now.