Bug 1005405 - Review Request: python-thrift - Thrift Python Software Library
Summary: Review Request: python-thrift - Thrift Python Software Library
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1005406
TreeView+ depends on / blocked
 
Reported: 2013-09-06 20:16 UTC by Dan Prince
Modified: 2015-12-06 21:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-28 09:12:04 UTC
Type: ---
i: fedora-review?

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Dan Prince 2013-09-06 20:16:10 UTC 
Spec URL: http://fedorapeople.org/~dprince/python-thrift.spec
SRPM URL: http://fedorapeople.org/~dprince/python-thrift-0.9.1-1.src.rpm

Description: Thrift is provided as a set of Python packages. The top level package is thrift, and there are subpackages for the protocol, transport, and server code. Each package contains modules using standard Thrift naming conventions i.e. TProtocol, TTransport) and implementations in corresponding module (i.e. TSocket).  There is also a subpackage reflection, which contains
the generated code for the reflection structures.

Fedora Account System Username: dprince

-------------

This is an upcoming requirement of OpenStack Ceilometer which requires python-happybase.
Comment 1 Christopher Meng 2013-09-07 07:03:48 UTC 
1. BuildRequires:  python-devel

---> BuildRequires:  python2-devel

Also missing BuildRequires:  python-setuptools

2. %description has duplicated line:

Thrift Python Software Library

Please remove it as it looks like weird.

3. No dist tag in %release.

4. * Fri Sep 6 2013 Dan Prince - 0.9.1-1

Where is your email?

5. Remove %defattr(-,root,root,-)
Comment 2 Christopher Meng 2013-09-24 00:22:33 UTC 
News here?
Comment 3 Christopher Meng 2013-11-09 07:55:38 UTC 
ping!
Comment 4 Christopher Meng 2014-03-28 09:12:04 UTC 
Conflicts with python-thrift in the repo(from "thrift" package) at least.
Note You need to log in before you can comment on or make changes to this bug.