Bug 1006123 - Rendered Diff freezes when diff is trying to compare files that have invalid XML
Summary: Rendered Diff freezes when diff is trying to compare files that have invalid XML
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: PressGang CCMS
Classification: Community
Component: Web-UI
Version: 1.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.2
Assignee: Matthew Casperson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1013825
TreeView+ depends on / blocked
 
Reported: 2013-09-10 04:50 UTC by Vikram Goyal
Modified: 2014-08-04 22:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-10-17 23:49:35 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Vikram Goyal 2013-09-10 04:50:26 UTC 
As in the title - if you try and see the rendered diff on two docs - one of which has an invalid XML - all the buttons get grayed out and nothing happens.
Comment 1 Matthew Casperson 2013-10-02 01:00:07 UTC 
Fixed in 201310021002

To test this, you can use topic 3737 revision 542432, which was saved with invalid XML. Getting a rendered diff of this revision will display an error message instead of just hanging.
Comment 2 Lee Newson 2013-10-02 01:55:54 UTC 
Note: This version is currently live on PressGang Next.
Comment 3 Matthew Casperson 2013-10-08 03:18:26 UTC 
Hours apply to 2013-10-1
Comment 4 Matthew Casperson 2013-10-16 04:21:36 UTC 
Tested this again, and had to make one small change to the message that was displayed when the error occurred, but this can be called fixed.
Note You need to log in before you can comment on or make changes to this bug.