Red Hat Bugzilla – Bug 1006449
If you try to create a storage connection with empty port, then it is set to 0
Last modified: 2016-02-10 13:54:55 EST
Created attachment 796066 [details]
test logs (vdsm, engine, server etc.)
Description of problem:
<port> tag is required when creating an iscsi storage connection. However, when you try the following call:
it succeeds and the created connection has port = 0:
<storage_connection href="/api/storageconnections/726a17f2-67c2-41a0-9fbc-9fed23a70271" id="726a17f2-67c2-41a0-9fbc-9fed23a70271">
Also, if you try to change existing connection and specified empty tag <port>, it will be set to 0.
Version-Release number of selected component (if applicable): is13
How reproducible: 100%, automated tests:
Steps to Reproduce:
1. try to create an iscsi storage connection and specify empty <port> tag
Actual results: connection is created with port = 0
Expected results: the operation should fail with appropriate error message
Allon, can you merge this change so that Ravi can backport it to 3.4? If not please retarget to 3.4.1 or 3.5.
(In reply to Juan Hernández from comment #3)
> Allon, can you merge this change so that Ravi can backport it to 3.4? If not
> please retarget to 3.4.1 or 3.5.
I merged it upstream. Considering the timing in 3.4's lifecycle and the severity of this issue, I pushed it out to 3.5.
Tried to create a storage connection with no value under port parameter and it failed with the following error:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<detail>[Invalid value for port, should be an integer greater than 0.]</detail>
Verified using ovirt-engine-3.5-beta
oVirt 3.5 has been released and should include the fix for this issue.