Bug 1007216 - Patch generator logic is present in EAP
Summary: Patch generator logic is present in EAP
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Patching
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ER6
: EAP 6.2.0
Assignee: Emanuel Muckenhuber
QA Contact: Jan Martiska
Russell Dickenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-12 06:39 UTC by Jan Martiska
Modified: 2015-02-01 23:05 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-15 16:22:38 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Jan Martiska 2013-09-12 06:39:05 UTC 
Customers with EAP shouldn't be allowed to generate their own patches. The generator logic should be moved from EAP sources to a separate repository.
Comment 1 John Doyle 2013-09-12 13:03:01 UTC 
Where is this, I have ER1 and don't know where it is.
Comment 2 Emanuel Muckenhuber 2013-09-12 13:07:49 UTC 
It's part of the codebase and therefore in the .jar. We do have restrictions on the modules export, so nothing should be able to consume this by chance. 

However i am going to remove the code once we found a permanent location for the patch generation tool.
Comment 3 Jan Martiska 2013-09-12 13:12:08 UTC 
The logic is in classes inside org/jboss/as/patching/main/wildfly-patching-7.3.0.Final-redhat-1.jar. The script for running the generator (patch-gen.sh) does not work in ER1, because of another issue - the module org.jboss.as.patching.generator is missing in ER1 (productization issue), but that issue is superseded by the fact that the generator logic should be removed completely.
Comment 8 Jan Martiska 2013-10-17 12:44:55 UTC 
Two files were probably forgotten and left in the codebase.
patching/src/main/java/org/jboss/as/patching/generator/Usage.java && UsageMessages.java

This actually does no harm, but Emanuel said he would delete them soon.
Setting this to VERIFIED as of 6.2.0.ER6.
Note You need to log in before you can comment on or make changes to this bug.