1. qmake-qt4 -> $qmake_qt4 

2. %{_datadir}/icons/hicolor/64x64/apps/%{name}.png
%{_datadir}/icons/hicolor/128x128/apps/%{name}.png

so you forgot to refresh icon cache

Spec URL: http://smani.fedorapeople.org/xflr5.spec
SRPM URL: http://smani.fedorapeople.org/xflr5-6.09.06-2.fc21.src.rpm

* Fri Sep 13 2013 Sandro Mani <manisandro> - 6.09.06-2
- Use qmake_qt4 macro
- Refresh icon cache

First, I checked sf.net page and can't find this version, so my question is: can you package the stable version? Or tell me why you refuse to do that.

No particular reason, except that I missed that the developer does not use trunk as the trunk, but branches/6.09-06...

So let's start over:

Spec URL: http://smani.fedorapeople.org/xflr5.spec
SRPM URL: http://smani.fedorapeople.org/xflr5-6.09.05-1.fc21.src.rpm

(In reply to Sandro Mani from comment #4)
> No particular reason, except that I missed that the developer does not use
> trunk as the trunk, but branches/6.09-06...
> 
> So let's start over:
> 
> Spec URL: http://smani.fedorapeople.org/xflr5.spec
> SRPM URL: http://smani.fedorapeople.org/xflr5-6.09.05-1.fc21.src.rpm

Ok.

If possible you can send an email to upstream about the release problem(But I think he will merge the branch when ready for stable or whatever.)

Review:

xflr5.i686: W: wrong-file-end-of-line-encoding /usr/share/doc/xflr5/License.txt
xflr5.i686: E: incorrect-fsf-address /usr/share/doc/xflr5/License.txt
xflr5.i686: W: wrong-file-end-of-line-encoding /usr/share/doc/xflr5/ReleaseNotes.txt

Also, licensecheck noticed a lot of incorrect FSF address problem.

Spec URL: http://smani.fedorapeople.org/xflr5.spec
SRPM URL: http://smani.fedorapeople.org/xflr5-6.09.05-2.fc21.src.rpm

* Fri Sep 13 2013 Sandro Mani <manisandro> - 6.09.05-2
- Fix line endings
- Add patch to fix fsf addresses

I've notified upstream about the FSF address problem [1].

[1] https://sourceforge.net/p/xflr5/discussion/679396/thread/3c53b4e2/

1. install -Dm 0644 --> install -PDm 0644

2. Use desktop-file-install to install desktop file, so you don't need to validate it.

desktop-file-install --dir=%{buildroot}%{_datadir}/applications/%{name}.desktop %{S:1}

3. Source0 should add full URL, also if stable remove comments.

Spec URL: http://smani.fedorapeople.org/xflr5.spec
SRPM URL: http://smani.fedorapeople.org/xflr5-6.09.05-3.fc21.src.rpm

* Fri Sep 13 2013 Sandro Mani <manisandro> - 6.09.05-3
- Use desktop-file-install
- Preserve timestamps

1. Do we really want this? I the selinux contexts are pretty much the default anyway. Or do you mean lower-case p to preserve the timestamps? In which case: done
2. Fair enough
3. As stated in the comments, there seems to be no URL for downloading the source tarball (only binary installers are distributed on the sourceforge page)

(In reply to Sandro Mani from comment #8)
> Spec URL: http://smani.fedorapeople.org/xflr5.spec
> SRPM URL: http://smani.fedorapeople.org/xflr5-6.09.05-3.fc21.src.rpm
> 
> * Fri Sep 13 2013 Sandro Mani <manisandro> - 6.09.05-3
> - Use desktop-file-install
> - Preserve timestamps
> 
> 1. Do we really want this? I the selinux contexts are pretty much the
> default anyway. Or do you mean lower-case p to preserve the timestamps? In
> which case: done

Oh...sorry for the TYPO.  -p

3. Should ask upstream to provide a source ball.

APPROVED.

3. Done: https://sourceforge.net/p/xflr5/discussion/679396/thread/3c53b4e2/

Thanks for the review!


New Package SCM Request
=======================
Package Name: xflr5
Short Description: Analysis tool for airfoils, wings and planes
Owners: smani
Branches: f19 f20
InitialCC:

Git done (by process-git-requests).

xflr5-6.09.05-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/xflr5-6.09.05-3.fc20

xflr5-6.09.05-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/xflr5-6.09.05-3.fc19

xflr5-6.09.05-3.fc20 has been pushed to the Fedora 20 testing repository.

xflr5-6.09.05-3.fc19 has been pushed to the Fedora 19 stable repository.