Bug 1007791 - Installer: Port offset configure only standalone profiles
Summary: Installer: Port offset configure only standalone profiles
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Installer
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ER2
: EAP 6.2.0
Assignee: Thomas Hauser
QA Contact: Petr Kremensky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-13 10:16 UTC by Petr Kremensky
Modified: 2017-10-10 00:07 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-15 16:15:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 900502 0 medium CLOSED Installer: Add the offset options to the ports panel 2021-02-22 00:41:40 UTC

Internal Links: 900502

Description Petr Kremensky 2013-09-13 10:16:49 UTC
On Socket binding screen choose to configure an offset for all default port bindings, choose some port offset and finish the installation. 

Actual result:
Only standalone profiles have port offset configured.

Expected result:
There will be port offset configured also for domain profiles.

Comment 1 Thomas Hauser 2013-09-13 19:05:41 UTC
Did some digging with this one. 

The installer currently modifies the port-offset attribute in jboss-eap-6.2/domain/configuration/host.xml. Here is the snippet:

http://pastebin.test.redhat.com/163884

As you can see, the installer currently changes the port-offset to server-one..but not server-two nor server-three. We have a few options:

a) Add the offset to the rest of the host.xml servers. This would just mean having the installer do a simple addition of the given value (the user gives X as the offset amount, then server-one will be offset by X, server-two by X+150, and server-three by X+250.

b) Add the offset directly to domain.xml in the relevant <socket-binding-group> element.

Comment 2 Petr Kremensky 2013-09-13 19:41:08 UTC
This is a tricky decision.
As there is nothing like <socket-binding-group/> for domain.xml, options you listed are IMO the only ones we have. 

I don't really like the idea of hard-coding the offset directly to each port inside domain.xml, so from my point of view the a) option is less evil, but if you prefer b) we can further discuss this.

Comment 3 Petr Kremensky 2013-09-13 19:45:44 UTC
User can always use custom port bindings to change ports inside domain.xml directly, so option a) is definitely better one.

Comment 4 Thomas Hauser 2013-09-16 15:40:40 UTC
option a) from my comment above has been added to the installer.

http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=e026d8f76d306996cab123265d9abb29d1c77949

Comment 5 Petr Kremensky 2013-09-18 09:42:26 UTC
Verified on EAP 6.2.0.ER2


Note You need to log in before you can comment on or make changes to this bug.