Bug 1008242 - Review Request: gti - Just a silly launcher
Review Request: gti - Just a silly launcher
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Christopher Meng
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2013-09-15 17:25 EDT by Benedikt Schäfer
Modified: 2014-08-28 06:35 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-08-28 06:35:31 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
i: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Benedikt Schäfer 2013-09-15 17:25:01 EDT
Spec URL: http://ib54003.fedorapeople.org/rpm/gti/f19/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/f19/gti-1.1.1-1.fc19.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003
Comment 1 Christopher Meng 2013-09-15 20:08:17 EDT
DON'T LIFT fedora-review flag BY YOURSELF.
Comment 2 Christopher Meng 2013-09-15 20:20:54 EDT
Let's start from SPEC itself first.

1. No need to use %{name} in %summary as it will be immutable if this software sdoesn't have some mass changes, so just use gti is good(3chars vs. 7chars), what do you think?

2. Its URL is http://r-wos.org/hacks/gti, not its github url.

3. Please visit its real homepage and change your %description. Too short.

4. If no %doc present, please remove the line with %doc

BUT, you MUST request a LICENSE from upstream or include it as %doc if it's already in the tarball.

5. %{_mandir}/man6/%{name}.6.gz

Please use

%{_mandir}/man6/%{name}.6* because RPM will help compress the ungzipped manpages if your makefile doesn't do that.
Comment 3 Michael Schwendt 2013-09-16 03:23:17 EDT
Run rpmlint (or rpmlint -i for more helpful output) on the src.rpm and all
built rpms. Feel free to ignore obvious false positives in the report, but fix
anything else. Preferably add a comment here about whether/when you think what
rpmlint reports is correct or incorrect.


> 1.

%{name} is completely wrong here: gti != git


> 4.

That's not a MUST but a SHOULD:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text


> 5.

It helps not just with uncompressed man pages, but also if the compression technique is changed. There's no immediate need to change it, it's just a hint for packagers since rpmbuild compressed man pages on-the-fly. In this case, the Makefile gzips the man page.


> %build
> make %{?_smp_mflags}

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages
Comment 4 Christopher Meng 2013-12-14 04:49:16 EST
ping here.
Comment 5 Christopher Meng 2013-12-19 05:55:09 EST
NEWS?
Comment 6 Benedikt Schäfer 2014-08-07 11:07:17 EDT
Hey,

sorry i was bussy... 

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003
Comment 7 Christopher Meng 2014-08-07 23:29:41 EDT
1. You'd better drop Group:Amusements/Games. Nonsense.

2. Read comment 3 carefully.

Don't erase the changelog in the past.

If you can't fix this for another long time, I will close this again.
Comment 8 Benedikt Schäfer 2014-08-08 02:19:11 EDT
- changed the GROUP to Nonsense

- contacted  Richard Wossal to provide license in source, still waiting for response

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003
Comment 9 Christopher Meng 2014-08-08 02:25:16 EDT
1. I meant drop.

2. Please read Michael's comment _carefully_:

> > %build
> > make %{?_smp_mflags}
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
> https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages
Comment 10 Benedikt Schäfer 2014-08-08 03:18:03 EDT
%build
make %{?_smp_mflags} CFLAGS="%{optflags}"

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003
Comment 11 Christopher Meng 2014-08-08 03:58:50 EDT
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.J9j6eF
+ umask 022
+ cd /builddir/build/BUILD
+ cd gti-1.2.0
+ make -j2 'CFLAGS=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
gcc -o gti  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables  gti.c
strip -s gti

Debug sumbols have been stripped.
Comment 12 Benedikt Schäfer 2014-08-08 05:23:33 EDT
-nostrip.patch

https://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-nostrip.patch

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003
Comment 13 Christopher Meng 2014-08-08 06:59:59 EDT
Forgot to mention, set LDFLAGS="%{?__global_ldflags}"
Comment 14 Benedikt Schäfer 2014-08-08 07:12:45 EDT
-LDFLAGS="%{?__global_ldflags}"

https://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-nostrip.patch

Spec URL: http://ib54003.fedorapeople.org/rpm/gti/gti.spec
SRPM URL: http://ib54003.fedorapeople.org/rpm/gti/gti-1.2.0-1.fc21.src.rpm
Description: Just a silly gti launcher, basically Inspired by sl.
Fedora Account System Username: ib54003
Comment 15 Christopher Meng 2014-08-09 04:10:30 EDT
PACKAGE APPROVED.
Comment 16 Benedikt Schäfer 2014-08-09 05:06:00 EDT
New Package SCM Request
=======================
Package Name: gti
Short Description: Just a silly gti launcher
Upstream URL: http://r-wos.org/hacks/gti
Owners: ib54003
Branches: f20
Comment 17 Gwyn Ciesla 2014-08-11 08:30:40 EDT
Git done (by process-git-requests).

Added f21.

Note You need to log in before you can comment on or make changes to this bug.