Hide Forgot
Description of problem: Recent RH BZ versions have a feature to show all bug activity on show_bug.cgi pages inlined in between bug comments. The CC field changes are not shown by default, there is a "Show CC Changes" link to show them. I wonder if it may be possible to extend that CC change hiding to other fields. The list of fields should be configurable per product or per user. Per product configuration seems preferred to me, as it allows hiding certain fields only when really needed, and have them displayed for products that do not require hiding. Reason for the request is that we do store long values in certain fields (whiteboards or cf_srt_notes) and change them often. As a consequence, bug activity display may add too much "noise" to certain bugs, making bug comments hard to follow. Example: https://bugzilla.redhat.com/show_bug.cgi?id=1002364#c4
Another option may be to see if we can handle changes of long values better. Maybe check if value changed is more than X characters, and if it is, truncate display with a js toggle to show full value.
(In reply to Tomas Hoger from comment #1) > Another option may be to see if we can handle changes of long values better. > Maybe check if value changed is more than X characters, and if it is, > truncate display with a js toggle to show full value. This is what I want to see happen. The question is how many character do we truncate at? My vote is 40 characters, which should be enough for most fields. The problem with the suggestion in comment #0 is what Tomas wants suppressed may be is what someone else wants to see. Additionally, if it is at a per-product level, and we hide say 'Doc Text', then the ECS team would need to know which products had this hidden, and which ones didn't.
(In reply to Simon Green from comment #2) > The question is how many character do we truncate at? My vote is 40 > characters, which should be enough for most fields. 40 sounds fairly low for summary at least. The current summary here should fit, the previous one would get truncated. Looking at the summary change you did with comment 2, it seems you can allow up to ~50 characters to have whole change only use single line, or ~100 to fit on two lines (which sounds ok to me). I think it would make sense to try first with 80 - 100. > The problem with the suggestion in comment #0 is what Tomas wants suppressed > may be is what someone else wants to see. Additionally, if it is at a > per-product level, and we hide say 'Doc Text', then the ECS team would need > to know which products had this hidden, and which ones didn't. I'm perfectly fine with truncation, it does have benefits over exclusion lists. Btw, I assume there's currently no way I can configure my account to show CC changes by default. Is there a way I failed to spot.
Ooops, sorry about the summary change.
(In reply to Tomas Hoger from comment #3) > ok to me). I think it would make sense to try first with 80 - 100. 100 chartacters works for me. > I'm perfectly fine with truncation, it does have benefits over exclusion > lists. > > Btw, I assume there's currently no way I can configure my account to show CC > changes by default. Is there a way I failed to spot. We took the extension from Mozilla, pretty much as is. Feel free to file a bug to get this changed to a preference (something that I too would like to see changed) (In reply to Tomas Hoger from comment #4) > Ooops, sorry about the summary change. :-)
(In reply to Simon Green from comment #5) > We took the extension from Mozilla, pretty much as is. Feel free to file a > bug to get this changed to a preference (something that I too would like to > see changed) Now that I re-read the above, I'm not sure if you expected me to file the bug here or in upstream BZ. I previously (mis-)read it as request to file upstream bug, so I created this (you're CCed): https://bugzilla.mozilla.org/show_bug.cgi?id=917827
This change is now live. If there are any issues, do not reopen this bug. Instead, you should create a new bug and reference this bug. -- simon
Looks great, thank you!