Description of problem:
I ran oo-admin-chk in INT and STG and got error messages like this:
[...snip...]
Gear '522fd80c03ef643aa1000467' has key with name 'cjk' in mongo but not on the node.
Gear '52300f056cec0ed2c5000261' has key with name 'cjk' in mongo but not on the node.
Gear '523013e76cec0eed870000d3' has  key with comment 'OPENSHIFT-523013e76cec0eed870000d3-5227fa0103ef64df75000031-f19' on the node but not in mongo.
Gear '523015c103ef6441e00000a1' has  key with comment 'OPENSHIFT-523015c103ef6441e00000a1-5227fa0103ef64df75000031-f19' on the node but not in mongo.
Gear '523015c103ef6441e00000a1' has key with name 'application-523015c103ef6441e00000a1' in mongo but not on the node.
Gear '52301f5f6cec0e305a000038' has key with name 'cjk' in mongo but not on the node.
Gear '5231283c6cec0eb47300020e' has key with name 'jenkins' in mongo but not on the node.
Gear '522ffea203ef643e0f000001' has key with name 'cjk' in mongo but not on the node.
Gear '523154866cec0ebc210003c6' has key with name 'cjk' in mongo but not on the node.
Gear '523157296cec0e251e000121' has key with name 'cjk' in mongo but not on the node.
Gear '523158fa03ef64acce0000ce' has key with name 'cjk' in mongo but not on the node.
Gear '5231840503ef6421e40002d0' has key with name 'cjk' in mongo but not on the node.
Gear '5231840503ef6421e40002dc' has key with name 'cjk' in mongo but not on the node.
Gear '5231840503ef6421e40002e8' has key with name 'cjk' in mongo but not on the node.
Gear '5231840503ef6421e40002cd' has key with name 'cjk' in mongo but not on the node.
Gear '5231862103ef64d6b300006f' has key with name 'cjk' in mongo but not on the node.
Gear '5231862103ef64d6b300006c' has key with name 'cjk' in mongo but not on the node.
Gear '52318cde03ef64d6b300018e' has key with name 'cjk' in mongo but not on the node.
[...snip...]


So I tried to repair the problems by running this:
oo-admin-repair -v --consumed-gears --ssh-keys --district-uids


and it error-ed saying this:
Total 1 applications have ssh key mismatches.

Fixing ssh key inconsistencies for all affected applications:
Fixing ssh keys for application: ...	FAIL
Failed to fix ssh key mismatches for application '': 
Problem:
  Calling Document.find with nil is invalid.
Summary:
  Document.find expects the parameters to be 1 or more ids, and will return a single document if 1 id is provided, otherwise an array of documents if multiple ids are provided.
Resolution:
  Most likely this is caused by passing parameters directly through to the find, and the parameter either is not present or the key from which it is accessed is incorrect.

Failed to fix ssh key mismatches for 1 applications.




This is happening in both INT and STG.

I tried to find an application that doesn't have a name set using the following mongo queries:

libra:PRIMARY> db.applications.find({'name' : null})
libra:PRIMARY> db.applications.find({'name' : ''})
libra:PRIMARY> 

Since I wasn't able to find anything, I think this is a bug in oo-admin-repair.

I was able to find the referred to application by looking it up by one of it's gears:
libra:PRIMARY> db.applications.findOne({'group_instances.gears.uuid' : gear_uuid}, {'name':true})
{ "_id" : ObjectId("5231840503ef6421e40002cd"), "name" : "cews1s0" }
libra:PRIMARY>


Notice that the application name is set properly.




Version-Release number of selected component (if applicable):
openshift-origin-broker-util-1.14.6-1.el6oso.noarch


How reproducible:
Very in INT and STG.


Steps to Reproduce:
1. Unknown, found in INT / STG


Actual results:
The error above


Expected results:
No error and it should fix the problem.