Bug 1008880 - Some serious logs don't support localization - JMX
Summary: Some serious logs don't support localization - JMX
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: JMX
Version: 6.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: DR1
: EAP 6.4.0
Assignee: Brian Stansberry
QA Contact: Nikoleta Hlavickova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-17 09:37 UTC by Petr Kremensky
Modified: 2019-08-19 12:46 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 900407 0 high CLOSED Messages not support JBoss Logging 2021-02-22 00:41:40 UTC

Internal Links: 900407

Description Petr Kremensky 2013-09-17 09:37:57 UTC
There are some serious log messages which don't support localization.

jboss-eap-6.2-src/webservices/tests-integration/src/main/java/org/jboss/as/webservices/deployer/RemoteDeployer.java
 - 152   LOGGER.warn("Trying to undeploy archive " + archiveURL + " which is not currently deployed!");

jboss-eap-6.2-src/system-jmx/src/main/java/org/jboss/system/ServiceMBeanSupport.java
 - 165   log.warn("Error in stop " + jbossInternalDescription(), t);
 - 173   log.warn("Error in destroy " + jbossInternalDescription(), t);
 - 220   log.warn("Initialization failed " + jbossInternalDescription(), e);
 - 253   log.warn("Starting failed " + jbossInternalDescription(), e);
 - 286   log.warn("Stopping failed " + jbossInternalDescription(), e);
 - 317   log.warn("Destroying failed " + jbossInternalDescription(), t);

Comment 1 James Perkins 2013-09-17 15:26:54 UTC
Reassigning to web services.

Comment 2 Alessio Soldano 2013-09-17 15:38:02 UTC
RemoteDeployer is used for test purposes only [1], so there's no need for it to support localization.

ServiceMBeanSupport is not part of the webservices subsystem or ws components.


[1] more in details, it's a support class used by the jbossws testsuite to deploy/undeploy test archives

Comment 4 Nikoleta Hlavickova 2014-02-19 09:57:00 UTC
There are still some failures in EAP 6.3.0 DR0:

jboss-eap-6.3-src/system-jmx/src/main/java/org/jboss/system/ServiceMBeanSupport.java
379   log.error(e);

jboss-eap-6.3-src/osgi/service/src/main/java/org/jboss/as/osgi/service/InitialDeploymentTracker.java
132   LOGGER.warnf("ServiceStartFailed: %s", serviceName);

jboss-eap-6.3-src/osgi/integration/http/src/main/java/org/jboss/as/osgi/httpservice/HttpServiceImpl.java
197   WEB_LOGGER.errorf(e, "");

jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/PatchArtifact.java
102   ctx.getErrorHandler().error("Failed to load identity info for patch " + patch.getPatchId(), e);
116   ctx.getErrorHandler().error("Failed to load previous patch", e);

jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/XmlFileState.java
51   ctx.getErrorHandler().error("File doesn't exist: " + file.getAbsolutePath());
56   ctx.getErrorHandler().error("Failed to parse file: " + file.getAbsolutePath(), e);

jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/validation/PatchElementProviderArtifact.java
84   ctx.getErrorHandler().error("Layer not found: " + metadata.getName());

jboss-eap-6.3-src/patching/src/main/java/org/jboss/as/patching/runner/IdentityPatchContext.java
435   PatchLogger.ROOT_LOGGER.warnf(e, "failed to undo change (%s)", modification);

jboss-eap-6.3-src/ejb3/src/main/java/org/jboss/as/ejb3/tx/CMTTxInterceptor.java
169   EjbLogger.ROOT_LOGGER.error(t);

Comment 5 Brian Stansberry 2014-02-19 14:06:21 UTC
Please file separate bugs per component, assigned to the relevant component lead. I'll use this one for the ServiceMBeanSupport one, as that is the component relevant to the initial report.

Comment 6 Brian Stansberry 2014-02-19 14:18:37 UTC
Never mind this time; I'll do them all. It's easier.

Comment 7 Nikoleta Hlavickova 2014-02-19 14:21:34 UTC
I have filed 2 BZs already:
BZ #1067019 and BZ #1067020

Comment 8 Nikoleta Hlavickova 2014-02-19 14:24:14 UTC
And here is the 3rd (last) one: BZ #1067024

Comment 9 Nikoleta Hlavickova 2014-07-08 07:02:02 UTC
The only fail in EAP 6.3.0.ER9 in JMX is:

jboss-eap-6.3-src/system-jmx/src/main/java/org/jboss/system/ServiceMBeanSupport.java
 - 379   log.error(e);

Comment 10 Brian Stansberry 2014-07-08 13:46:11 UTC
I didn't submit my planned PR for this because the upstream changes couldn't be merged until after 6.3 work was in blockers-only mode. I'll send up a PR today but I expect it won't be merged for 6.3.0.

Comment 11 Brian Stansberry 2014-07-08 17:38:16 UTC
Withdrawing my dev_ack for 6.3 as it is too late for the WFLY-2964 backport.

The PR for the backport for 6.4 is https://github.com/jbossas/jboss-eap/pull/1505

Comment 12 Nikoleta Hlavickova 2014-09-19 12:40:50 UTC
Verified with EAP 6.4.0.DR1.1


Note You need to log in before you can comment on or make changes to this bug.