Bug 1011183 - Review Request: sisu-mojos - Sisu plugin for Apache Maven
Summary: Review Request: sisu-mojos - Sisu plugin for Apache Maven
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: gil cattaneo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-23 17:49 UTC by Mikolaj Izdebski
Modified: 2013-11-20 18:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-13 12:39:59 UTC
Type: ---
Embargoed:
puntogil: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
review notes (7.93 KB, text/plain)
2013-09-23 19:46 UTC, gil cattaneo
no flags Details

Description Mikolaj Izdebski 2013-09-23 17:49:09 UTC
Spec URL: http://mizdebsk.fedorapeople.org/review/sisu-mojos/sisu-mojos.spec
SRPM URL: http://mizdebsk.fedorapeople.org/review/sisu-mojos/sisu-mojos-0.0.0-0.1.M5.fc21.src.rpm
Description: The Sisu Plugin for Maven provides mojos to generate
META-INF/sisu/javax.inject.Named index files for the Sisu container.
Fedora Account System Username: mizdebsk

Comment 1 gil cattaneo 2013-09-23 19:46:19 UTC
Created attachment 801865 [details]
review notes

all seem ok except for
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java/sisu-mojos
please, fix unowned directory before import

approved

Comment 2 Mikolaj Izdebski 2013-09-24 09:48:50 UTC
Thank you for the review.
I will fix unowned directory at SCM import.

Comment 3 Mikolaj Izdebski 2013-09-24 09:49:26 UTC
New Package SCM Request
=======================
Package Name: sisu-mojos
Short Description: Sisu plugin for Apache Maven
Owners: mizdebsk msrb sochotni
Branches: f20
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2013-09-24 12:25:42 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.