Bug 1011485 - Review Request: global - a source code tag system
Summary: Review Request: global - a source code tag system
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michal Schmidt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-24 12:13 UTC by Jiri Pirko
Modified: 2016-06-14 12:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-14 12:54:58 UTC
Type: ---
mschmidt: fedora-review?


Attachments (Terms of Use)

Description Jiri Pirko 2013-09-24 12:13:11 UTC
Spec URL: http://people.redhat.com/jpirko/fedora_pkg_review/global_1/global.spec
SRPM URL: http://people.redhat.com/jpirko/fedora_pkg_review/global_1/global-6.2.9-1.fc19.src.rpm
Description:
GNU GLOBAL is a source code tag system that works the same way across
diverse environments. It supports C, C++, Yacc, Java, PHP and
assembler source code.

Fedora Account System Username: jirka

Comment 1 Michal Schmidt 2013-12-11 14:54:08 UTC
> Group: Development/Tools

The "Group" tag is not mandatory, but you can keep it if you want (for compatibility with EPEL).
http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

> License: GPLv2+ and BSD

Looking in the tarball I found it's actually GPL v3 or higher.

I'm not sure what parts are supposed to be under the BSD license. Hm, it looks like the upstream tarball bundles several independent libraries. That's frowned upon in Fedora. Please try to remove the bundled stuff in the %prep step and see if it builds and works fine with the system libraries.
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries

> %defattr(-,root,root,-)

It should no longer be needed to specify this explicitly.
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

Comment 3 Upstream Release Monitoring 2015-09-24 15:04:13 UTC
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117


Note You need to log in before you can comment on or make changes to this bug.