Bug 1012077 - Review Request: python-qpid_messaging - Python bindings for the Qpid messaging framework
Summary: Review Request: python-qpid_messaging - Python bindings for the Qpid messagin...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sandro Mani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-09-25 16:23 UTC by Darryl L. Pierce
Modified: 2015-06-22 00:08 UTC (History)
3 users (show)

Fixed In Version: python-qpid_messaging-0.24-3.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-25 20:56:25 UTC
Type: ---
manisandro: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Darryl L. Pierce 2013-09-25 16:23:59 UTC
Spec URL: http://mcpierce.fedorapeople.org/rpms/python-qpid_messaging.spec
SRPM URL: http://mcpierce.fedorapeople.org/rpms/python-qpid_messaging-0.24-1.fc19.src.rpm
Description: Python bindings for the Qpid messaging framework
Fedora Account System Username: mcpierce

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5983811

Comment 1 Sandro Mani 2013-09-25 17:24:16 UTC
Polishing:
- %defattr(-,root,root,-) is unnecessary
- make install DESTDIR=%{buildroot} can be replaced by %make_install
- escape the % in the comments (i.e. % -> %%)
- typo in changelog: <dpierce@redhat.com -> <dpierce@redhat.com> (note the final >)
- is _pkgdocdir needed?
- document patches (issue, upstream status)

Issues:
- empty debuginfo package 

Rpmlint:
python-qpid_messaging.x86_64: W: unstripped-binary-or-object /usr/lib64/python2.7/site-packages/_qpid_messaging.so
python-qpid_messaging.src:59: W: macro-in-comment %{buildroot}
python-qpid_messaging.src:59: W: macro-in-comment %{_datadir}
python-qpid_messaging.src:70: W: macro-in-comment %doc
python-qpid_messaging.src:70: W: macro-in-comment %{_datadir}
python-qpid_messaging.src: W: file-size-mismatch python-qpid_messaging-0.24.tar.gz = 9410, http://www.apache.org/dist/qpid/0.24/python-qpid_messaging-0.24.tar.gz = 9518
2 packages and 0 specfiles checked; 0 errors, 6 warnings.


Rest looks good.

Comment 2 Darryl L. Pierce 2013-09-25 18:48:10 UTC
(In reply to Sandro Mani from comment #1)
> Polishing:
> - %defattr(-,root,root,-) is unnecessary

Removed it.

> - make install DESTDIR=%{buildroot} can be replaced by %make_install

Replaced it.

> - escape the % in the comments (i.e. % -> %%)

That's a place holder for an update that'll include Python example apps.

> - typo in changelog: <dpierce@redhat.com -> <dpierce@redhat.com> (note the
> final >)

Fixed.

> - is _pkgdocdir needed?

Yeah, there's going to be documentation (including the above mentioned examples) in an upcoming update.

> - document patches (issue, upstream status)

Added the JIRA number for each patch (all are QPID-4952).

> Issues:
> - empty debuginfo package 

> Rpmlint:
> python-qpid_messaging.x86_64: W: unstripped-binary-or-object
> /usr/lib64/python2.7/site-packages/_qpid_messaging.so
> python-qpid_messaging.src:59: W: macro-in-comment %{buildroot}
> python-qpid_messaging.src:59: W: macro-in-comment %{_datadir}
> python-qpid_messaging.src:70: W: macro-in-comment %doc
> python-qpid_messaging.src:70: W: macro-in-comment %{_datadir}
> python-qpid_messaging.src: W: file-size-mismatch
> python-qpid_messaging-0.24.tar.gz = 9410,
> http://www.apache.org/dist/qpid/0.24/python-qpid_messaging-0.24.tar.gz = 9518
> 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
> 
> 
> Rest looks good.

Updated SPEC:  http://mcpierce.fedorapeople.org/rpms/python-qpid_messaging.spec
Updated SRPM:  http://mcpierce.fedorapeople.org/rpms/python-qpid_messaging-0.24-2.fc19.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5984389

Comment 3 Sandro Mani 2013-09-25 19:01:40 UTC
Rpmlint still complains about
python-qpid_messaging.x86_64: W: unstripped-binary-or-object /usr/lib64/python2.7/site-packages/_qpid_messaging.so
According to [1], solution is to make sure binaries are executable.


Everything else is ok, so I'll approve the package. But check whether you can get rid of that warning.


[1] http://fedoraproject.org/wiki/Common_Rpmlint_issues#unstripped-binary-or-object

Comment 4 Darryl L. Pierce 2013-09-25 19:11:42 UTC
(In reply to Sandro Mani from comment #3)
> Rpmlint still complains about
> python-qpid_messaging.x86_64: W: unstripped-binary-or-object
> /usr/lib64/python2.7/site-packages/_qpid_messaging.so
> According to [1], solution is to make sure binaries are executable.

Hrm, that's very strange. I built locally, ran rpmlint on the output files and that error didn't occur. I added a macro to address the issue.

> Everything else is ok, so I'll approve the package. But check whether you
> can get rid of that warning.
> 
> 
> [1]
> http://fedoraproject.org/wiki/Common_Rpmlint_issues#unstripped-binary-or-
> object

Thank you!

Comment 5 Darryl L. Pierce 2013-09-25 19:13:22 UTC
New Package SCM Request
=======================
Package Name: python-qpid_messaging
Short Description: Python bindings for the Qpid messaging framework
Owners: mcpierce
Branches: f18 f19 f20 rawhide
InitialCC: mcpierce

Comment 6 Gwyn Ciesla 2013-09-25 19:26:03 UTC
Git done (by process-git-requests).

No need to request rawhide, devel is automatic.

Comment 7 Fedora Update System 2013-09-25 20:19:57 UTC
python-qpid_messaging-0.24-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-qpid_messaging-0.24-3.fc20

Comment 8 Fedora Update System 2013-09-25 20:39:34 UTC
python-qpid_messaging-0.24-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-qpid_messaging-0.24-3.fc19

Comment 9 Fedora Update System 2013-09-25 20:54:33 UTC
python-qpid_messaging-0.24-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-qpid_messaging-0.24-3.fc18

Comment 10 Fedora Update System 2013-10-03 01:09:53 UTC
python-qpid_messaging-0.24-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 11 Fedora Update System 2013-10-06 01:30:16 UTC
python-qpid_messaging-0.24-3.fc18 has been pushed to the Fedora 18 stable repository.

Comment 12 Fedora Update System 2013-10-06 01:30:42 UTC
python-qpid_messaging-0.24-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 13 Darryl L. Pierce 2014-02-18 18:32:50 UTC
Package Change Request
======================
Package Name: perl-qpid_messaging
New Branches: epel7
Owners: mcpierce

Comment 14 Darryl L. Pierce 2014-02-18 18:33:00 UTC
Package Change Request
======================
Package Name: python-qpid_messaging
New Branches: epel7
Owners: mcpierce

Comment 15 Gwyn Ciesla 2014-02-18 18:39:12 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.