Red Hat Bugzilla – Bug 1013545
Rule validation has no result if date-effective or date-expires option has wrong date format
Last modified: 2014-08-06 16:17:52 EDT
Created attachment 805069 [details]
server.log with exception stack trace
Description of problem:
date-effective and date-expires rule options in GRE has a plain text input. User has no idea what the expected date format is. If the option contains value in wrong format validation of the rule gives no UI result due to server-side exception. The same applies for DRL Editor validation.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. open any Guided Rule
2. add date-effective option, leave it blank or fill in yyyy-MM-dd date
3. click Validate
No UI response. User has no idea what is wrong with the rule.
The invalid date format error should be propagated to the client. Date picker for input field in GRE would be a plus.
Assigning this to Mario to make sure the builder is properly catching and reporting the exception. After that is done, if still not working, please assign the issue back to Michael to verify why the UI is not picking that up.
I am now catching and raising a compilation error when those dates are in the wrong format.
Fixed by https://github.com/droolsjbpm/drools/commit/955939aed
Now it is not possible to input incorrect date format for date-* options.
1. Date picker widget always generates the text date in the correct format.
2. Manually input date is reset to today if the input isn't correct.
It is possible to save incorrect date outside the guided editor using git. The behaviour is then a little inconsistent, though. The rule can be opened in guided editor. Validation reports wrong date format. However project build passes successfully. Shouldn't it fail if there are invalid rules in the project? (This is a candidate for a new ticket.)