Bug 1014362 - Versioned requires without spaces around operator causes strange traceback
Summary: Versioned requires without spaces around operator causes strange traceback
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-01 19:52 UTC by Ian Weller
Modified: 2013-10-04 04:54 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-10-04 04:54:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Relevant section of log (5.03 KB, text/plain)
2013-10-01 19:52 UTC, Ian Weller
no flags Details

Description Ian Weller 2013-10-01 19:52:10 UTC
Created attachment 806159 [details]
Relevant section of log

Including a Requires line such as:

> Requires:       php>=5.1.2

causes fedora-review to traceback after running an invalid repoquery command.

Putting spaces around the operator fixes the issue.

Attached is the relevant part of the log.

Comment 1 Alec Leamas 2013-10-03 12:54:02 UTC
Hi!

Thanks for reporting this. Could you please provide info on what package you were reviewing when this happened? Preferably, the complete command line when invoking fedora-review?

Comment 2 Ian Weller 2013-10-03 18:18:52 UTC
The review in question was bug 1014353. (Fortunately because the package needed to be renamed, the bug-inducing spec is still there!)

http://puiterwijk.fedorapeople.org//lightopenid.spec

The command line was fedora-review -P PHP -b 1014353, but to cause the bug you'll have to specify the older spec/SRPM, I think.

Comment 3 Alec Leamas 2013-10-04 04:54:45 UTC
Thanks again for report and swift feedback. This is now fixed [2] in devel, should it become a problem for you once again before next release please refer  to [1] for using the devel version.

--alec


[1] https://fedorahosted.org/FedoraReview/wiki/UseDevelopmentVersion
[2] http://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=fbf7e8e


Note You need to log in before you can comment on or make changes to this bug.