Hide Forgot
Description of problem: I'm unable to build inkscape using source data from src.rpm. We use it to execute upstream testsets (via `make check`). There is an extra comma "," at the end of one line. In upstream I can see the extra character is removed correctly. Version-Release number of selected component (if applicable): inkscape-0.48.4-7.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. get src.rpm, extract sources and after configuring execute `make` Actual results: ... In file included from desktop.cpp:91:0: widgets/desktop-widget.h:242:32: error: stray ‘,’ at end of member declaration GtkWidget *commands_toolbox,; ^ ... Expected results: inkscape should be built correctly Additional info:
You should run tests on patched sources by doing 'rhpkg prep' or 'rpmbuild -bp' with srpm. Otherwise you're testing original sources and not sources which was actually used to build the package. The wrong widgets/desktop-widget.h is in upstream tarball, see http://downloads.sourceforge.net/inkscape/inkscape-0.48.4.tar.gz if interested. However it is fixed in latest trunk, so . We have inkscape-0.48.4-spuriouscomma.h patch to fix this problem.