Bug 1015801 - missing unbound patch?
Summary: missing unbound patch?
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: vpnc
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Christian Krause
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-05 16:03 UTC by Laurent Jacquot
Modified: 2014-11-08 11:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-08 11:35:46 UTC
Type: Bug


Attachments (Terms of Use)

Description Laurent Jacquot 2013-10-05 16:03:35 UTC
It seems the patch was added in the src.rpm but not in the vpnc.spec file.

Am I confused?

cat vpnc.spec
....
Patch1:         vpnc-0.5.1-dpd.patch
Patch2:         vpnc-0.5.3-use-autodie.patch
Patch3:         vpnc-0.5.3-unbound-support.patch
....
...
%prep
%setup -q
%patch1 -p1 -b .dpd
%patch2 -p1 -b .autodie
...

Comment 1 Felix Schwarz 2014-11-02 21:50:51 UTC
The reason is that this patch was incorporated directly into Fedora's vpnc-script so technically it's not needed as a patch file anymore. The separate patch was removed from the Fedora git repo shortly after your ticket (	df0906121b052568da4bd8153c811b1b8f0941b9, 0.5.3-20.svn457.fc19) and is not present in git anymore.

The only thing which seems to be missing is a proper build for F19 as the real fix was only in 0.5.3-20 but according to https://apps.fedoraproject.org/packages/vpnc the latest version for F19 is still 0.5.3-19.

However if you don't the patch for bug 865092 in F19 I guess you're all set. Please close the ticket in case your question was answered :-)

(Even though I agree that it is not really the best approach to patch scripts from upstream without clearly a visible patch process.)

Comment 2 Felix Schwarz 2014-11-08 11:35:46 UTC
As mentioned in my previous comment the unbound patch is applied in F20+. F19 goes end-of-life support soon so I'm for fixing only critical bugs at this stage. Please reopen if you *really* need F19 support.


Note You need to log in before you can comment on or make changes to this bug.