Red Hat Bugzilla – Bug 1016476
Review Request: spring-retry - Abstraction around retrying failed operations
Last modified: 2013-10-28 23:49:54 EDT
Spec URL: http://msrb.fedorapeople.org/review/spring-retry.spec
SRPM URL: http://msrb.fedorapeople.org/review/spring-retry-1.0.2-1.fc21.src.rpm
Description: Spring Retry provides an abstraction around retrying failed operations,
with an emphasis on declarative control of the process and policy-based
bahaviour that is easy to extend and customize. For instance, you can
configure a plain POJO operation to retry if it fails, based on the type
of exception, and with a fixed or exponential backoff.
Fedora Account System Username: msrb
i would like to take this review
org.aspectj:aspectjrt classes are available in the (our,Debian,*Ubuntu) aspectjweaver package, if you want run same tests
Created attachment 809378 [details]
NON blocking issues
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[!]: Package does not include license text files separate from upstream.
please, contact upstream to include a license copy
[?]: If tests are skipped during package build explain why it was needed in a
Note: Tests seem to be skipped. Verify there is a commment giving a
reason for this
see previous comment
(In reply to gil cattaneo from comment #2)
> org.aspectj:aspectjrt classes are available in the (our,Debian,*Ubuntu)
> aspectjweaver package, if you want run same tests
Thanks for the info. Package aspectjweaver in Fedora only provides org.aspectj:aspectjweaver. Maybe only alias is missing. I will check if it works with spring-retry.
can you add also OSGi manifest?
%pom_add_plugin org.apache.felix:maven-bundle-plugin . '
if project.organization.name is equal to SpringSource
No problem, I will add OSGi metadata. I have also opened pull request for adding ASL 2.0 license text and tests are enabled now.
New Package SCM Request
Package Name: spring-retry
Short Description: Abstraction around retrying failed operations
Owners: msrb sochotni mizdebsk msimacek
Git done (by process-git-requests).
Thanks for the review and the repo. The package is now available in Rawhide.