Bug 1016947 - Review Request: python-iscpy - Python library to parse ISC style config files
Summary: Review Request: python-iscpy - Python library to parse ISC style config files
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-09 02:45 UTC by Yohan Graterol
Modified: 2023-09-14 01:51 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-05-23 13:44:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Yohan Graterol 2013-10-09 02:45:59 UTC
python-iscpy

Python library to parse ISC style config files

SPEC: http://yograterol.fedorapeople.org/python-iscpy.spec
SRPM: http://yograterol.fedorapeople.org/python-iscpy-1.05-1.fc19.src.rpm

FAS User: yograterol

Comment 1 Eduardo Echeverria 2013-10-09 03:21:59 UTC
rpmlint -v python-iscpy-1.05-1.fc20.noarch.rpm 
python-iscpy.noarch: I: checking
******
python-iscpy.noarch: I: checking-url https://pypi.python.org/pypi/iscpy (timeout 10 seconds)
python-iscpy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/iscpy/iscpy_dns/named_importer_lib.py 0644L /usr/bin/env
python-iscpy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/iscpy/iscpy_core/core.py 0644L /usr/bin/env
python-iscpy.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/iscpy/__init__.py 0644L /usr/bin/python
1 packages and 0 specfiles checked; 3 errors, 2 warnings.

Please change shebang for invoking the default interpreter, and take care of the permissions

I can't see any test on the build phase
+ cd iscpy-1.05
++ pwd
+ PYTHONPATH=/builddir/build/BUILD/iscpy-1.05
+ /usr/bin/python setup.py test
running test
+ exit 0

Seems that not there any explicit requires 
➜  iscpy-1.05  ls -la | grep -ri "import"
iscpy/iscpy_core/core.py:import copy
iscpy/iscpy_core/core.py:import cPickle
iscpy/iscpy_dns/named_importer_lib.py:import copy
iscpy/iscpy_dns/named_importer_lib.py:import iscpy
iscpy/__init__.py:from iscpy_core.core import *
iscpy/__init__.py:import iscpy_dns.named_importer_lib as dns
test/named_importer_lib_regtest.py:import unittest
test/named_importer_lib_regtest.py:import os
test/named_importer_lib_regtest.py:import iscpy
test/named_importer_lib_regtest.py:class TestNamedImport(unittest.TestCase):
test/blank_named_regtest.py:import unittest
test/blank_named_regtest.py:import os
test/blank_named_regtest.py:import iscpy
test/blank_named_regtest.py:class TestNamedImport(unittest.TestCase):
ez_setup/__init__.py:    from ez_setup import use_setuptools
ez_setup/__init__.py:import sys
ez_setup/__init__.py:import sys, os
ez_setup/__init__.py:try: from hashlib import md5
ez_setup/__init__.py:except ImportError: from md5 import md5
ez_setup/__init__.py:    was_imported = 'pkg_resources' in sys.modules or 'setuptools' in sys.modules
ez_setup/__init__.py:        import setuptools; setuptools.bootstrap_install_from = egg
ez_setup/__init__.py:        import pkg_resources
ez_setup/__init__.py:    except ImportError:
ez_setup/__init__.py:        if was_imported:
ez_setup/__init__.py:    import urllib2, shutil
ez_setup/__init__.py:            from distutils import log
ez_setup/__init__.py:                ); from time import sleep; sleep(delay)
ez_setup/__init__.py:        import setuptools
ez_setup/__init__.py:    except ImportError:
ez_setup/__init__.py:            from setuptools.command.easy_install import main
ez_setup/__init__.py:    import pkg_resources
ez_setup/__init__.py:            from setuptools.command.easy_install import main
ez_setup/__init__.py:        except ImportError:
ez_setup/__init__.py:            from easy_install import main
ez_setup/__init__.py:            from setuptools.command.easy_install import main
ez_setup/__init__.py:    import re
ez_setup/__init__.py:    import inspect
iscpy.egg-info/SOURCES.txt:iscpy/iscpy_dns/named_importer_lib.py
iscpy.egg-info/SOURCES.txt:test/named_importer_lib_regtest.py
setup.py:    from setuptools import setup, find_packages
setup.py:except ImportError:
setup.py:    from ez_setup import use_setuptools
setup.py:    from setuptools import setup, find_packages
setup.py:import sys, os
MANIFEST:iscpy/iscpy_dns/named_importer_lib.py

Please fix the issues, and I will do the review,

Comment 2 William Moreno 2015-07-27 17:45:28 UTC
Any update here?

Can I take the review?

Comment 3 William Moreno 2015-08-09 16:59:40 UTC
Hi, do want to continue with this review?

Comment 4 Gwyn Ciesla 2017-05-23 13:44:53 UTC
Doesn't build, please reopen if still interested in this package.

Comment 5 Red Hat Bugzilla 2023-09-14 01:51:49 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.