Bug 1019639 - Save VM with --bypass-cache on /tmp should report as "VM can't be saved on /tmp as it doesn't support O_DIRECT" instead of throwing error as Invalid argument"
Save VM with --bypass-cache on /tmp should report as "VM can't be saved on /t...
Status: CLOSED DEFERRED
Product: Virtualization Tools
Classification: Community
Component: libvirt (Show other bugs)
unspecified
All Linux
unspecified Severity low
: ---
: ---
Assigned To: Libvirt Maintainers
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-16 03:52 EDT by chandrashekar shastri
Modified: 2016-05-02 11:00 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-05-02 11:00:46 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
IBM Linux Technology Center 97736 None None None Never

  None (edit)
Description chandrashekar shastri 2013-10-16 03:52:23 EDT
Description of problem:

If we try to save the VM with --bypass-cache on /tmp directory Invalid argument instead of saving the VM is not supported on the /tmp which does not support O_DIRECT.

virsh save --domain vm2 --file "/tmp/vm2_save" --verbose  --bypass-cache --running 

error: Failed to save domain vm2 to /tmp/vm2_save
error: Failed to create file '/tmp/vm2_save': Invalid argument

Instead of throwing error as "Invalid argument" it should give the information to the user as " Saving a domain is /tmp directory is not supported".
Comment 1 Cole Robinson 2016-05-02 11:00:46 EDT
It's not about /tmp specifically, it's about tmpfs not supported O_DIRECT, which is a known problem. This is the error we get from strerror here. Given the relative obscurity of this issue WRT saving I don't think this is too interesting to try and guess in libvirt code

Note You need to log in before you can comment on or make changes to this bug.