Bug 1020809 - Please simplify %perl_default_filter
Please simplify %perl_default_filter
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: perl (Show other bugs)
20
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-18 06:21 EDT by Remi Collet
Modified: 2013-10-22 07:11 EDT (History)
9 users (show)

See Also:
Fixed In Version: perl-5.18.1-289.fc21
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-10-22 07:11:34 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Remi Collet 2013-10-18 06:21:00 EDT
See : https://fedorahosted.org/fpc/ticket/353

So, the %perl_default_filter macro definition could be simplyfy

-%global __provides_exclude_from %{perl_vendorarch}/auto/.*\\\\.so$|%{perl_archlib}/.*\\\\.so$|%{_docdir}
+%global __provides_exclude_from %{_docdir}

This change will be reflected in 
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Perl
Comment 1 Remi Collet 2013-10-18 06:21:50 EDT
To be clear "the %perl_default_filter macro definition could be simplify in Fedora >= 20"
Comment 2 Petr Pisar 2013-10-22 02:41:40 EDT
We will see. I will do some tests and in case of success, I will implement it in F21.
Comment 3 Petr Pisar 2013-10-22 03:40:58 EDT
So it seems to work.

However I would like to sanity the filters too: To anchor the expressions and to append them instead of redefining:

-%global __provides_exclude_from %{_docdir}
-%global __requires_exclude_from %{_docdir}
-%global __provides_exclude perl\\\\(VMS|perl\\\\(Win32|perl\\\\(DB\\\\)|perl\\\\(UNIVERSAL\\\\)
-%global __requires_exclude perl\\\\(VMS|perl\\\\(Win32
+%global __provides_exclude_from %{?__provides_exclude_from:%__provides_exclude_from|}^%{_docdir}
+%global __requires_exclude_from %{?__requires_exclude_from:%__requires_exclude_from|}^%{_docdir}
+%global __provides_exclude {?__provides_exclude:%__provides_exclude|}^perl\\\\(VMS|perl\\\\(Win32|perl\\\\(DB\\\\)|^perl\\\\(UNIVERSAL\\\\)
+%global __requires_exclude {?__requires_exclude:%__requires_exclude|}^perl\\\\(VMS|^perl\\\\(Win32
Comment 4 Petr Pisar 2013-10-22 04:00:35 EDT
(In reply to Petr Pisar from comment #3)
> So it seems to work.
> 
> However I would like to sanity the filters too: To anchor the expressions
> and to append them instead of redefining:
> 
Correct new values would be:

%global __provides_exclude_from %{?__provides_exclude_from:%__provides_exclude_from|}^%{_docdir}
%global __requires_exclude_from %{?__requires_exclude_from:%__requires_exclude_from|}^%{_docdir}
%global __provides_exclude %{?__provides_exclude:%__provides_exclude|}^perl\\\\(VMS|^perl\\\\(Win32|^perl\\\\(DB\\\\)|^perl\\\\(UNIVERSAL\\\\)
%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\\\(VMS|^perl\\\\(Win32
Comment 5 Petr Pisar 2013-10-22 05:22:18 EDT
(In reply to Petr Pisar from comment #3)
> However I would like to sanity the filters too: To anchor the expressions
> and to append them instead of redefining:
> 
And this works too. I'm going to push this version. I will create automated tests and package them for Fedora to have a canary.

Note You need to log in before you can comment on or make changes to this bug.