Bug 1021016 - V2CartModel#get_cartridge_from_directory fails with "Can't convert Nil to String" to ident is missing
Summary: V2CartModel#get_cartridge_from_directory fails with "Can't convert Nil to Str...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Paul Morie
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-18 19:25 UTC by Paul Morie
Modified: 2015-05-14 23:30 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-24 03:25:25 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Paul Morie 2013-10-18 19:25:15 UTC
Comment 1 Paul Morie 2013-10-21 14:47:26 UTC 
Expected behavior is for a more descriptive error to be raised when the ident file is missing.
Comment 2 openshift-github-bot 2013-10-21 20:45:46 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/110c8973549dfdf9e9df0f9e700283163cb384b6
Fix bug 1021016
Comment 3 Meng Bo 2013-10-22 09:43:59 UTC 
Checked on devenv_3927, the meaningful error was shown when upgrading gear without env OPENSHIFT_*_IDENT.



                    "Unhandled exception performing step: Cartridge Ident not found in /var/lib/openshift/52662b8d92e9752d43000010/jbosseap\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:164:in `get_cartridge_from_directory'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:79:in `block in each_cartridge'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:1072:in `block in process_cartridges'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:1070:in `each'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:1070:in `process_cartridges'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/v2_cart_model.rb:78:in `each_cartridge'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/upgrade.rb:286:in `block in compute_itinerary'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/utils/upgrade_progress.rb:32:in `step'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/upgrade.rb:280:in `compute_itinerary'\n/opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-node-1.16.1/lib/openshift-origin-node/model/upgrade.rb:156:in `execute'\n/opt/rh/ruby193/root/usr/libexec/mcollective/mcollective/agent/openshift.rb:243:in `upgrade_action'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/rpc/agent.rb:86:in `handlemsg'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/agents.rb:126:in `block (2 levels) in dispatch'\n/opt/rh/ruby193/root/usr/share/ruby/timeout.rb:69:in `timeout'\n/opt/rh/ruby193/root/usr/share/ruby/mcollective/agents.rb:125:in `block in dispatch'"


Move bug to verified.
Note You need to log in before you can comment on or make changes to this bug.