Bug 1021919 - Review Request: simarrange - STL 2D plate packer with collision simulation
Summary: Review Request: simarrange - STL 2D plate packer with collision simulation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1008284
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-22 10:29 UTC by Miro Hrončok
Modified: 2013-12-01 02:51 UTC (History)
3 users (show)

Fixed In Version: simarrange-0.0-1.20131019gitd52382f.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-23 19:33:11 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Miro Hrončok 2013-10-22 10:29:23 UTC
Spec URL: https://raw.github.com/hroncok/SPECS/master/simarrange.spec
SRPM URL: http://churchyard.fedorapeople.org/SRPMS/simarrange-0.0-1.20131019gitd52382f.fc19.src.rpm

Description:
Simarrange is a program that simulates collisions between STL meshes in 2D in
order to generate tightly packed sets of parts. It takes a directory of STL
files as input and outputs STL files with combined plates of parts.
The parts are assumed to be in the correct printable orientation already.

Fedora Account System Username: churchyard

Note: rpmlint warns about AGPLv3+, but I found it at https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
The (only) source clearly says "...either version 3 of the License, or (at your option) any later version."

Comment 1 Christopher Meng 2013-10-22 15:13:39 UTC
Taken.

Comment 2 Miro Hrončok 2013-10-27 14:08:24 UTC
admesh has been built for rawhide.

Comment 3 Christopher Meng 2013-11-08 14:21:13 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "AGPL (v3 or later)", "Unknown or generated". 1 files have unknown
     license. Detailed output of licensecheck in
     /home/rpmaker/Desktop/simarrange/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: simarrange-0.0-1.20131019gitd52382f.fc21.i686.rpm
          simarrange-0.0-1.20131019gitd52382f.fc21.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint simarrange
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
simarrange (rpmlib, GLIBC filtered):
    libadmesh.so.1
    libargtable2.so.0
    libc.so.6
    libgcc_s.so.1
    libgcc_s.so.1(GCC_3.3.1)
    libgomp.so.1
    libgomp.so.1(GOMP_1.0)
    libgomp.so.1(OMP_1.0)
    libm.so.6
    libopencv_core.so.2.4
    libopencv_highgui.so.2.4
    libopencv_imgproc.so.2.4
    libpthread.so.0
    rtld(GNU_HASH)



Provides
--------
simarrange:
    simarrange
    simarrange(x86-32)



Source checksums
----------------
https://github.com/kliment/simarrange/archive/d52382feb716621f9ac08d25a502420fc1d3c983/simarrange-0.0-d52382f.tar.gz :
  CHECKSUM(SHA256) this package     : 4da53018d5c00711bd4adca08bf0fb468072b2e259030cb80d66a61567002f28
  CHECKSUM(SHA256) upstream package : 4da53018d5c00711bd4adca08bf0fb468072b2e259030cb80d66a61567002f28


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -rvn simarrange-0.0-1.20131019gitd52382f.fc19.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

----------------------------
PACKAGE APPROVED.

Comment 4 Miro Hrončok 2013-11-09 13:22:42 UTC
Thanks.

Comment 5 Miro Hrončok 2013-11-09 13:23:43 UTC
New Package SCM Request
=======================
Package Name: simarrange
Short Description: STL 2D plate packer with collision simulation
Owners: churchyard
Branches: f18 f19 f20 el6

Comment 6 Gwyn Ciesla 2013-11-11 12:59:13 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-11-11 16:41:35 UTC
simarrange-0.0-1.20131019gitd52382f.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/simarrange-0.0-1.20131019gitd52382f.fc20

Comment 8 Fedora Update System 2013-11-11 16:42:46 UTC
simarrange-0.0-1.20131019gitd52382f.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/simarrange-0.0-1.20131019gitd52382f.fc19

Comment 9 Fedora Update System 2013-11-11 16:45:34 UTC
simarrange-0.0-1.20131019gitd52382f.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/simarrange-0.0-1.20131019gitd52382f.fc18

Comment 10 Fedora Update System 2013-11-13 01:59:15 UTC
simarrange-0.0-1.20131019gitd52382f.fc19 has been pushed to the Fedora 19 testing repository.

Comment 11 Fedora Update System 2013-11-13 18:16:07 UTC
simarrange-0.0-1.20131019gitd52382f.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/simarrange-0.0-1.20131019gitd52382f.el6

Comment 12 Fedora Update System 2013-11-23 19:33:11 UTC
simarrange-0.0-1.20131019gitd52382f.fc19 has been pushed to the Fedora 19 stable repository.

Comment 13 Fedora Update System 2013-11-23 19:33:37 UTC
simarrange-0.0-1.20131019gitd52382f.fc18 has been pushed to the Fedora 18 stable repository.

Comment 14 Fedora Update System 2013-11-24 03:31:49 UTC
simarrange-0.0-1.20131019gitd52382f.fc20 has been pushed to the Fedora 20 stable repository.

Comment 15 Fedora Update System 2013-12-01 02:51:11 UTC
simarrange-0.0-1.20131019gitd52382f.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.