Bug 1021986 - BeakerLib should submit just the phase-relevant log on rlPhaseEnd
Summary: BeakerLib should submit just the phase-relevant log on rlPhaseEnd
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: beakerlib
Version: 26
Hardware: Unspecified
OS: Unspecified
low
unspecified
Target Milestone: ---
Assignee: Dalibor Pospíšil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1198878 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-22 12:49 UTC by Petr Muller
Modified: 2018-01-15 21:37 UTC (History)
4 users (show)

Fixed In Version: beakerlib-1.17-6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-15 21:37:02 UTC
Type: Bug


Attachments (Terms of Use)
phase relevant logs (869 bytes, patch)
2015-03-05 09:32 UTC, Dalibor Pospíšil
no flags Details | Diff
phase relevant logs (1.14 KB, patch)
2015-03-05 15:57 UTC, Dalibor Pospíšil
no flags Details | Diff

Description Petr Muller 2013-10-22 12:49:50 UTC
Description of problem:
Currently, rlPhaseEnd builds a textual output for the whole test so far, including previous (and already submitted) phases. This leads to the same information being submitted all over again, which is wasteful.

BeakerLib should submit only the piece of the test relevant to the phase currently ended.

Comment 1 Fedora Admin XMLRPC Client 2014-09-02 12:13:41 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Jaroslav Reznik 2015-03-03 16:56:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 3 Chunyu Hu 2015-03-05 09:08:35 UTC
*** Bug 1198878 has been marked as a duplicate of this bug. ***

Comment 4 Dalibor Pospíšil 2015-03-05 09:32:23 UTC
Created attachment 998250 [details]
phase relevant logs

I have created a patch trying to solve this issue, please review it if this solution is ok.

Comment 5 Dalibor Pospíšil 2015-03-05 15:57:57 UTC
Created attachment 998442 [details]
phase relevant logs

I realized that my previous patch was too naive. I have improved it.

Comment 6 Chunyu Hu 2015-03-06 08:43:25 UTC
(In reply to Dalibor Pospíšil from comment #5)
> Created attachment 998442 [details]
> phase relevant logs
> 
> I realized that my previous patch was too naive. I have improved it.

hi Dalibor, 
I tried your patch, find that the log is 7  lines shorter than expected. The reason is that at the end of the journal-all.txt , will append 7 lines summary,looks like the following, as a result, the log of the phase will miss the header and start lines.

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: /kernel/errata/Regression
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   LOG    ] :: Phases: 33 good, 1 bad
:: [   FAIL   ] :: RESULT: /kernel/errata/Regression


Here is a log of one phase using the current patch. 
http://beaker-archive.app.eng.bos.redhat.com/beaker-logs/2015/03/8974/897465/1852339/28726852/141919589/test_log-Test-bz500299.log



I tried to Changed to : cat "$logfile" | tail -n +$((log_size-7+1)) > $logfile2 , have another try:
http://beaker-archive.app.eng.bos.redhat.com/beaker-logs/2015/03/8974/897465/1852339/28726852/141923281/test_log-Test-bz634462.log
---
thanks.
Chunyu

Comment 7 Dalibor Pospíšil 2015-03-06 12:20:41 UTC
The patch was a blind patch. I did not do any testing. But while I am thinking about it. It would be probably better to create a new functionality in journallig.py to avoid any unwanted outputs.

Comment 8 Petr Muller 2015-07-20 11:14:18 UTC
(In reply to Dalibor Pospíšil from comment #7)
> The patch was a blind patch. I did not do any testing. But while I am
> thinking about it. It would be probably better to create a new functionality
> in journallig.py to avoid any unwanted outputs.

I agree.

Comment 9 Fedora End Of Life 2016-07-19 20:46:42 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 10 Fedora End Of Life 2017-02-28 09:35:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.


Note You need to log in before you can comment on or make changes to this bug.