Bug 1022995 - quota: moving files between directories does not update the size field properly
Summary: quota: moving files between directories does not update the size field properly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: quota
Version: pre-release
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
Assignee: Raghavendra G
QA Contact:
URL:
Whiteboard:
Depends On: 871015
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-24 12:24 UTC by Raghavendra G
Modified: 2014-04-17 11:50 UTC (History)
11 users (show)

Fixed In Version: glusterfs-3.5.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 871015
Environment:
Last Closed: 2014-04-17 11:50:02 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Comment 1 Anand Avati 2013-10-24 12:30:46 UTC 
REVIEW: http://review.gluster.org/6138 (features/marker: don't honour GLUSTERFS_INTERNAL_FOP_KEY) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 2 Anand Avati 2013-10-28 05:57:06 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 3 Anand Avati 2013-10-28 05:57:15 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 4 Anand Avati 2013-10-28 05:57:23 UTC 
REVIEW: http://review.gluster.org/6154 (core: introduce internal fop types) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 5 Anand Avati 2013-10-28 10:21:30 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#2) for review on master by Raghavendra G (rgowdapp)
Comment 6 Anand Avati 2013-10-28 10:21:39 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#2) for review on master by Raghavendra G (rgowdapp)
Comment 7 Anand Avati 2013-10-28 10:21:57 UTC 
REVIEW: http://review.gluster.org/6154 (core: introduce internal fop types) posted (#2) for review on master by Raghavendra G (rgowdapp)
Comment 8 Anand Avati 2013-10-28 13:49:42 UTC 
REVIEW: http://review.gluster.org/6138 (features/marker: don't honour GLUSTERFS_INTERNAL_FOP_KEY) posted (#2) for review on master by Krishnan Parthasarathi (kparthas)
Comment 9 Anand Avati 2013-10-28 16:38:30 UTC 
REVIEW: http://review.gluster.org/6138 (features/marker: don't honour GLUSTERFS_INTERNAL_FOP_KEY) posted (#3) for review on master by Krishnan Parthasarathi (kparthas)
Comment 10 Anand Avati 2013-10-31 06:02:45 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#3) for review on master by Raghavendra G (rgowdapp)
Comment 11 Anand Avati 2013-10-31 06:02:56 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#3) for review on master by Raghavendra G (rgowdapp)
Comment 12 Anand Avati 2013-10-31 06:03:35 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 13 Anand Avati 2013-10-31 06:03:44 UTC 
REVIEW: http://review.gluster.org/6204 (features/marker: remove dead code in unlink codepath.) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 14 Anand Avati 2013-11-04 11:13:00 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#4) for review on master by Raghavendra G (rgowdapp)
Comment 15 Anand Avati 2013-11-04 11:13:11 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#2) for review on master by Raghavendra G (rgowdapp)
Comment 16 Anand Avati 2013-11-04 11:13:19 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#4) for review on master by Raghavendra G (rgowdapp)
Comment 17 Anand Avati 2013-11-04 11:13:53 UTC 
REVIEW: http://review.gluster.org/6204 (features/marker: remove dead code in unlink codepath.) posted (#2) for review on master by Raghavendra G (rgowdapp)
Comment 18 Anand Avati 2013-11-11 13:58:01 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#5) for review on master by Raghavendra G (rgowdapp)
Comment 19 Anand Avati 2013-11-11 13:58:10 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#3) for review on master by Raghavendra G (rgowdapp)
Comment 20 Anand Avati 2013-11-11 13:58:23 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#5) for review on master by Raghavendra G (rgowdapp)
Comment 21 Anand Avati 2013-11-11 13:59:02 UTC 
REVIEW: http://review.gluster.org/6204 (features/marker: remove dead code in unlink codepath.) posted (#3) for review on master by Raghavendra G (rgowdapp)
Comment 22 Anand Avati 2013-11-11 16:32:07 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#6) for review on master by Raghavendra G (rgowdapp)
Comment 23 Anand Avati 2013-11-11 16:32:19 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#4) for review on master by Raghavendra G (rgowdapp)
Comment 24 Anand Avati 2013-11-11 16:32:27 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#6) for review on master by Raghavendra G (rgowdapp)
Comment 25 Anand Avati 2013-11-11 18:07:21 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#7) for review on master by Raghavendra G (rgowdapp)
Comment 26 Anand Avati 2013-11-11 18:07:30 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#5) for review on master by Raghavendra G (rgowdapp)
Comment 27 Anand Avati 2013-11-11 18:07:38 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#7) for review on master by Raghavendra G (rgowdapp)
Comment 28 Anand Avati 2013-11-12 15:12:35 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#8) for review on master by Raghavendra G (rgowdapp)
Comment 29 Anand Avati 2013-11-12 15:12:45 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#6) for review on master by Raghavendra G (rgowdapp)
Comment 30 Anand Avati 2013-11-12 15:12:55 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#8) for review on master by Raghavendra G (rgowdapp)
Comment 31 Anand Avati 2013-11-12 15:13:35 UTC 
REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#1) for review on master by Raghavendra G (rgowdapp)
Comment 32 Anand Avati 2013-11-13 11:17:13 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#9) for review on master by Raghavendra G (rgowdapp)
Comment 33 Anand Avati 2013-11-13 11:17:23 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#7) for review on master by Raghavendra G (rgowdapp)
Comment 34 Anand Avati 2013-11-13 11:17:31 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#9) for review on master by Raghavendra G (rgowdapp)
Comment 35 Anand Avati 2013-11-13 11:17:40 UTC 
REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#2) for review on master by Raghavendra G (rgowdapp)
Comment 36 Anand Avati 2013-11-14 12:03:40 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#10) for review on master by Raghavendra G (rgowdapp)
Comment 37 Anand Avati 2013-11-14 12:03:49 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#8) for review on master by Raghavendra G (rgowdapp)
Comment 38 Anand Avati 2013-11-14 12:03:59 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#10) for review on master by Raghavendra G (rgowdapp)
Comment 39 Anand Avati 2013-11-14 12:04:08 UTC 
REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#3) for review on master by Raghavendra G (rgowdapp)
Comment 40 Anand Avati 2013-11-14 12:44:23 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#11) for review on master by Raghavendra G (rgowdapp)
Comment 41 Anand Avati 2013-11-14 12:44:31 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#9) for review on master by Raghavendra G (rgowdapp)
Comment 42 Anand Avati 2013-11-14 12:44:43 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#11) for review on master by Raghavendra G (rgowdapp)
Comment 43 Anand Avati 2013-11-14 12:44:52 UTC 
REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#4) for review on master by Raghavendra G (rgowdapp)
Comment 44 Anand Avati 2013-11-26 06:05:36 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#28) for review on master by Raghavendra G (rgowdapp)
Comment 45 Anand Avati 2013-11-26 06:05:47 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#26) for review on master by Raghavendra G (rgowdapp)
Comment 46 Anand Avati 2013-11-26 06:05:56 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#28) for review on master by Raghavendra G (rgowdapp)
Comment 47 Anand Avati 2013-11-26 10:45:23 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#29) for review on master by Raghavendra G (rgowdapp)
Comment 48 Anand Avati 2013-11-26 10:45:37 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#27) for review on master by Raghavendra G (rgowdapp)
Comment 49 Anand Avati 2013-11-26 10:45:53 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#29) for review on master by Raghavendra G (rgowdapp)
Comment 50 Anand Avati 2013-11-26 11:40:37 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#30) for review on master by Raghavendra G (rgowdapp)
Comment 51 Anand Avati 2013-11-26 11:40:47 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#28) for review on master by Raghavendra G (rgowdapp)
Comment 52 Anand Avati 2013-11-26 11:40:57 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#30) for review on master by Raghavendra G (rgowdapp)
Comment 53 Anand Avati 2013-11-26 12:28:34 UTC 
REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#31) for review on master by Raghavendra G (rgowdapp)
Comment 54 Anand Avati 2013-11-26 12:28:43 UTC 
REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#29) for review on master by Raghavendra G (rgowdapp)
Comment 55 Anand Avati 2013-11-26 12:28:54 UTC 
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#31) for review on master by Raghavendra G (rgowdapp)
Comment 56 Anand Avati 2013-11-26 18:26:52 UTC 
COMMIT: http://review.gluster.org/6152 committed in master by Anand Avati (avati) 
------
commit 1a2f51144fcbd920a6f3769d6b2f3ceeefdc220d
Author: Raghavendra G <rgowdapp>
Date:   Thu Nov 14 17:10:09 2013 +0530

    core: add dht_is_linkfile helper procedure.
    
    components other than distribute (like marker to exclude linkfiles
    from being accounted) also need awareness of what constitutes a
    linkfile. Hence its good to separate out this functionality into
    core.
    
    Change-Id: Ib944eeacc991bb1de464c9e73ee409fc7a689ff1
    BUG: 1022995
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/6152
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
Comment 57 Anand Avati 2013-11-26 18:27:14 UTC 
COMMIT: http://review.gluster.org/6153 committed in master by Anand Avati (avati) 
------
commit 75f66a98dad3882aff4a68cf0648016101f0a416
Author: Raghavendra G <rgowdapp>
Date:   Mon Oct 28 10:32:52 2013 +0530

    features/marker-quota: exclude dht-linkfiles from being accounted.
    
    Change-Id: I3239f5e8477664dcc04434e4d455ae447493a7ac
    BUG: 1022995
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/6153
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
Comment 58 Anand Avati 2013-11-26 18:27:32 UTC 
COMMIT: http://review.gluster.org/6203 committed in master by Anand Avati (avati) 
------
commit 33e0df30cbffbfbda5197704d0f788c83cd7ed78
Author: Raghavendra G <rgowdapp>
Date:   Thu Oct 31 06:35:47 2013 +0530

    cluster/dht: instruct marker whenever it shouldn't do accounting
    
    This is needed for two reasons:
    
    * since dht-linkfiles are internal, they shouldn't be accounted.
    * hardlink handling in marker is broken. link/unlink of hardlinks
      present in same directory can break marker accounting. Hence, if src
      and dst are in same directory in case of rename, dht - if it breaks
      rename into link/unlink operations - should instruct marker to not to
      do accounting.
    
    Change-Id: I9c9f7384569f75a2792f6450ee7a5279bf751ae7
    BUG: 1022995
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/6203
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
Comment 59 Niels de Vos 2014-04-17 11:50:02 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.