Hide Forgot
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-innertube.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-innertube-1.1.0-1.fc21.src.rpm Description: Innertube is a thread-safe, re-entrant resource pool, extracted from the Riak Ruby Client, where it was used to pool connections to Riak. Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6109941
Taking this one. I would appreciate it if you would have time to review my review request bug 1024168 .
Well, I tried checking your srpm and the rebuilt binary rpms carefully, and I did not find any blockers for this package. One recommendation * Separated license text - I recommend to rename "LICENSE" to something unique to this srpm, like "LICENSE.innertube", then again rename when building this srpm, in case some other srpm also has a file "LICENSE" and this file may overwritten when srpms are expanded (on ~/rpmbuild/SOURCES/, for example) - spec / srpm clean - builds file - can be installed cleanly - seems to work
----------------------------------------------------------- This package (rubygem-innertube) is APPROVED by mtasaka -----------------------------------------------------------
Thanks for the review. Regarding the LICENSE file, I was hoping to keep it the same as the URL's file name, and I can see the advantage to what you're suggesting also. Changed at http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-innertube.git/commit/?id=57a20ab7e0c75ea8eb8e71794355d195501b9535
New Package SCM Request ======================= Package Name: rubygem-innertube Short Description: A thread-safe resource pool Owners: ktdreyer Branches: f19 f20
Git done (by process-git-requests).
rubygem-innertube-1.1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-innertube-1.1.0-2.fc20
rubygem-innertube-1.1.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-innertube-1.1.0-2.fc19
rubygem-innertube-1.1.0-2.fc20 has been pushed to the Fedora 20 testing repository.
rubygem-innertube-1.1.0-2.fc20 has been pushed to the Fedora 20 stable repository.
rubygem-innertube-1.1.0-2.fc19 has been pushed to the Fedora 19 stable repository.