Bug 1025254 - vorbisgain FTBFS if "-Werror=format-security" flag is used
Summary: vorbisgain FTBFS if "-Werror=format-security" flag is used
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: vorbisgain
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brian Pepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-31 10:26 UTC by Dhiru Kholia
Modified: 2014-03-25 03:44 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-10-31 14:02:20 UTC
Type: Bug


Attachments (Terms of Use)
vorbisgain FTBFS fix (333 bytes, patch)
2013-10-31 10:26 UTC, Dhiru Kholia
no flags Details | Diff

Description Dhiru Kholia 2013-10-31 10:26:25 UTC
Created attachment 817810 [details]
vorbisgain FTBFS fix

vorbisgain-0.36-12.fc20 fails to build if "-Werror=format-security" flag is used.

...
gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -fsigned-char -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -c `test -f 'misc.c' || echo './'`misc.c
misc.c: In function ‘file_error’:
misc.c:59:5: error: format not a string literal and no format arguments [-Werror=format-security]
     fprintf(stderr, strerror(err_num));
     ^
...

I am working on a proposal to enable "-Werror=format-security" for all packages. For more details, please see https://fedorahosted.org/fesco/ticket/1185 URL.

I have attached a trivial patch to fix this problem. Please review and apply.

Comment 1 Brian Pepple 2013-10-31 14:02:20 UTC
Thanks for the patch.

Fixed in vorbisgain-0.36-13.fc21.


Note You need to log in before you can comment on or make changes to this bug.