Bug 1025485 - Git push reports deployments to the broker twice
Summary: Git push reports deployments to the broker twice
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Image
Version: 2.x
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Ben Parees
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-10-31 19:23 UTC by Andy Goldstein
Modified: 2015-05-15 00:34 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-02-26 19:08:10 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Andy Goldstein 2013-10-31 19:23:34 UTC
Description of problem: When pushing changes to an application, the deployments are reported to the broker twice


Version-Release number of selected component (if applicable):


How reproducible: 100%


Steps to Reproduce:
1. Create app
2. Make a change
3. Git push

Actual results:

Broker log will show DeploymentsController#create called twice

Expected results:

Broker log will show DeploymentsController#create called just once


Additional info:

We report deployments in post_receive and in activate_local_gear, and post_receive ultimately invokes activate_local_gear. It's probably sufficient just to report deployments in activate_local_gear and remove the call from post_receive.

Comment 2 openshift-github-bot 2014-01-22 21:21:35 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/274a0067bb6008a49e6fff9e4d2f3c10e8ce7e48
Bug 1025485 - Git push reports deployments to the broker twice

Comment 3 chunchen 2014-01-23 11:16:55 UTC
It's fixed, verified on devenv_4263, please refer to the following results:

1. Create app
2. Make a change
3. Git push

# tail -f development.log | grep -i DeploymentsController

2014-01-23 06:14:47.138 [INFO ] Processing by DeploymentsController#create as JSON (pid:2673)


Note You need to log in before you can comment on or make changes to this bug.