Bug 1026367 - openshift-iptables-port-proxy service script should enable net.ipv4.conf.all.route_localnet
Summary: openshift-iptables-port-proxy service script should enable net.ipv4.conf.all....
Keywords:
Status: CLOSED EOL
Alias: None
Product: OKD
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-04 14:11 UTC by Brenton Leanhardt
Modified: 2017-01-25 06:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-25 06:38:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Brenton Leanhardt 2013-11-04 14:11:34 UTC
Description of problem:

The openshift-iptables-port-proxy service script will not function properly if net.ipv4.conf.all.route_localnet is disabled.  Typically this is a step performed as part of an OpenShift deployment.  However, as a safety check it should be temporarily enabled in this service script.

I say temporary because admins in different environments may have their own procedure for persisting sysctl changes.  This change will warn the admin to persist the setting and mention that it is being temporarily enabled.

Comment 1 Brenton Leanhardt 2013-11-04 14:15:12 UTC
https://github.com/openshift/origin-server/pull/4076/

Comment 2 openshift-github-bot 2013-11-05 00:55:20 UTC
Commits pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/1739970621d219b37e1a73c2fbfab14c9b854e3a
Bug 1026367 - openshift-iptables-port-proxy service script should enable net.ipv4.conf.all.route_localnet

https://github.com/openshift/origin-server/commit/748d0bfd1d94d1ffde464014e03e62c56120638f
Bug 1026367 - starting openshift-iptables-port-proxy after the network is up

https://github.com/openshift/origin-server/commit/b6c3655f6f826cdcbf4d48ad02e4088b59d887b8
Bug 1026367 - Improving oo-admin-ctl-iptables-port-proxy "UI"

Previously the restart, reload, stop and status commands were noop.  This can
be confusing for admins.

Now:

stop: flushes the rhc-app-comm chain
restart: calls stop then start
reload: calls start
status: removed

The motivation for this is the following:

1 Admin sees something weird with the rhc-app-comm chain not working as expected
2 Admin runs `for s in 'iptables network openshift-iptables-port-proxy'; do server $s restart'
3 Admin notices rhc-app-comm is still empty and is really confused

In this case the event that trigged #1 is that net.ipv4.conf.all.route_localnet
wasn't set in /etc/sysctl.conf.

https://github.com/openshift/origin-server/commit/8e723d6171b9b910cece2898f4ab61301fa12b2c
Bug 1026367 - Moving the sysctl logic to oo-admin-ctl-iptables-port-proxy

Comment 3 Michal Fojtik 2013-11-20 11:38:26 UTC
ON_QA?


Note You need to log in before you can comment on or make changes to this bug.