Description of problem: Check code of dns_bind_update_record function in oo-accept-broker. It is using "$10", not "${10}". Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Is there a particular line number causing the problem? I ran oo-accept-broker -v and didn't have any syntax errors.
(In reply to Brenton Leanhardt from comment #2) > Is there a particular line number causing the problem? I ran > oo-accept-broker -v and didn't have any syntax errors. This is really a minor issue, no obvious error is seen when running oo-accept-node, # oo-accept-broker -v <--snip--> INFO: checking bind dns plugin configuration INFO: DNS Server: 10.4.59.165 INFO: DNS Port: 53 INFO: DNS Zone: ose-1105.com.cn INFO: DNS Domain Suffix: ose-1105.com.cn INFO: DNS Update Auth: key INFO: DNS Key Name: ose-1105.com.cn INFO: DNS Key Value: ***** INFO: adding txt record named testrecord.ose-1105.com.cn to server 10.4.59.165: key0 INFO: txt record successfully added INFO: deleteing txt record named testrecord.ose-1105.com.cn to server 10.4.59.165: key0 INFO: txt record successfully deleted <--snip--> Take note the above output, the test DNS record value is "key0", actually the value passed to dns_bind_update_record function is "this_is_a_test", but in the code, it is using $10, then the value of this var is replaced by "key0". $1="key" $10="key0" it should be: ${10}="this_is_a_test"
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/096f6ecb3b4df40b71c4ebda6f434bcc8379d17f Bug 1027268 - syntax error is seen in oo-accept-broker
Verified this bug with openshift-origin-broker-util-1.17.0-1.git.175.379e798.el6op.noarch, and PASS. # oo-accept-broker -v <--snip--> INFO: checking bind dns plugin configuration INFO: DNS Server: 192.168.59.220 INFO: DNS Port: 53 INFO: DNS Zone: ose-1107.com.cn INFO: DNS Domain Suffix: ose-1107.com.cn INFO: DNS Update Auth: key INFO: DNS Key Name: ose-1107.com.cn INFO: DNS Key Value: ***** INFO: adding txt record named testrecord.ose-1107.com.cn to server 192.168.59.220: this_is_a_test INFO: txt record successfully added INFO: deleteing txt record named testrecord.ose-1107.com.cn to server 192.168.59.220: INFO: txt record successfully deleted <--snip-->