Bug 1028550 - jansi-native: doesn't install attached artifacts with proper classifiers
Summary: jansi-native: doesn't install attached artifacts with proper classifiers
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: jansi-native
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1049937
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-08 18:38 UTC by Stanislav Ochotnicky
Modified: 2014-03-07 13:27 UTC (History)
4 users (show)

Fixed In Version: 1.5-4
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1028551 (view as bug list)
Environment:
Last Closed: 2014-03-07 13:27:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed patch (1.23 KB, patch)
2014-01-10 18:15 UTC, Mikolaj Izdebski
no flags Details | Diff

Description Stanislav Ochotnicky 2013-11-08 18:38:19 UTC
Description of problem:
If current version of jansi-native is rebuilt it will produce incomplete RPMs due to attached artifacts with "linux<bits>" classifiers not being installed. This can be fixed by adding following line to %prep:

%mvn_package :::linux%{bits}: __default

Version-Release number of selected component (if applicable):
jansi-native-1.5-1.fc21

How reproducible:
always

Steps to Reproduce:
1. rebuild package in current rawhide
2. look at rpm provides
3. notice missing linux64/linux32 mvn() provides

Actual results:
missing architecture mvn() provides

Expected results:
mvn(org.fusesource.jansi:jansi-native::linux64:) = 1.4
or
mvn(org.fusesource.jansi:jansi-native::linux32:) = 1.4

provides generated

Comment 1 Stanislav Ochotnicky 2013-11-11 09:00:40 UTC
While we are at it, adding aarch64 to bits macro would be good I believe

Comment 2 Mikolaj Izdebski 2013-11-11 13:10:26 UTC
(In reply to Stanislav Ochotnicky from comment #1)
> While we are at it, adding aarch64 to bits macro would be good I believe

64-bit ARM can also be "arm64" or "armv8".  While we're at this
I would also add ia64, alpha, ppc64p7.

Comment 3 Peter Robinson 2014-01-10 17:44:05 UTC
Fixed in a generic not needing to list all architectures in this commit:
http://pkgs.fedoraproject.org/cgit/jansi-native.git/commit/?id=f6eca4ca7934c7643bfa0cf64be6faf19b8c8417

Comment 4 Mikolaj Izdebski 2014-01-10 18:11:01 UTC
It's still not fixed, as of 1.5-3.

$ repoquery --provides jansi-native
jansi-native = 1.5-3.fc21
jansi-native(x86-64) = 1.5-3.fc21
mvn(org.fusesource.jansi:jansi-native) = 1.5
osgi(org.fusesource.jansi.native) = 1.5.0

Neither of provides specified in "Expected results" in comment #0 are present.

Comment 5 Mikolaj Izdebski 2014-01-10 18:15:30 UTC
Created attachment 848339 [details]
Proposed patch

Comment 6 Zenon Panoussis 2014-01-19 09:43:36 UTC
The linux%{bits} problem is also present in rhel7.

Comment 7 Zenon Panoussis 2014-01-19 19:11:17 UTC
And I should add that %{bits} doesn't work for me. 

On x86_64:

rpm --eval %{bits}
%{bits}

rpm --eval %{__isa_bits}
64

On i686:

rpm --eval %{bits}
%{bits}

rpm --eval %{__isa_bits}
32

Comment 8 Stanislav Ochotnicky 2014-01-20 09:15:32 UTC
(In reply to Zenon Panoussis from comment #7)
> And I should add that %{bits} doesn't work for me. 
> 
> On x86_64:
> 
> rpm --eval %{bits}
> %{bits}
> 
> rpm --eval %{__isa_bits}
> 64
> 
> On i686:
> 
> rpm --eval %{bits}
> %{bits}
> 
> rpm --eval %{__isa_bits}
> 32

bits macro is defined in the spec file, it's not otherwise known to rpm

Comment 9 Mikolaj Izdebski 2014-01-22 20:08:21 UTC
(In reply to Zenon Panoussis from comment #6)
> The linux%{bits} problem is also present in rhel7.

For RHEL 7 see bug #1028551.

Comment 10 Mikolaj Izdebski 2014-03-07 13:27:48 UTC
Fixed in jansi-native-1.5-4

Comment 11 Mikolaj Izdebski 2014-03-07 13:27:57 UTC
I believe that this bug is fixed in jansi-native-1.5-4,
which is available in Fedora Rawhide, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=502091


Note You need to log in before you can comment on or make changes to this bug.