Bug 102951 - netdevice.h should not include byteorder.h
netdevice.h should not include byteorder.h
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: glibc-kernheaders (Show other bugs)
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Arjan van de Ven
Brian Brock
Depends On:
  Show dependency treegraph
Reported: 2003-08-22 21:25 EDT by Felipe Alfaro Solana
Modified: 2007-11-30 17:06 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2003-08-25 08:52:05 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Felipe Alfaro Solana 2003-08-22 21:25:51 EDT
Description of problem: 
The "/usr/include/linux/netdevice.h" file from glibc-kernheaders-2.4-8.28 
includes, at line #35, file "byteorder.h". There are two problems here: 
1. "byteorder.h" is under the "asm" directory, so the #include should be 
directed against <asm/byteorder.h> 
2. "byteorder.h" is a kernel private include file that should not ever be 
included by any user-space program. 
Version-Release number of selected component (if applicable): 
How reproducible: 
Steps to Reproduce: 
Try building "chkrootkit" against glibc-kernheaders-2.4-8.29 and you'll see 
what I'm talking about ;-) 
Actual results: 
User space applications that include "/usr/include/linux/netdevice.h" won't 
Expected results: 
--- netdevice.h.old     2003-08-23 03:20:19.000000000 +0200 
+++ netdevice.h 2003-08-23 03:21:44.000000000 +0200 
@@ -32,7 +32,6 @@ 
 #include <asm/types.h> 
 #include <asm/cache.h> 
 #include <endian.h> 
-#include <byteorder.h> 
Additional info:
Comment 1 Arjan van de Ven 2003-08-23 07:11:57 EDT
it should have been byteswap.h instead... woops.
Thanks for the report; I've built a fix package into the tree
Comment 2 Jay Turner 2003-08-25 08:52:05 EDT
Fix confirmed with 2.4-8.31.

Note You need to log in before you can comment on or make changes to this bug.