Bug 1030228 - numerous fd's opened on samba-gluster log file by smbd process
Summary: numerous fd's opened on samba-gluster log file by smbd process
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: pre-release
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Poornima G
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On: 1004794
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-14 08:22 UTC by Poornima G
Modified: 2014-04-17 11:50 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.5.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1004794
Environment:
Last Closed: 2014-04-17 11:50:41 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2013-11-14 10:53:42 UTC
REVIEW: http://review.gluster.org/6263 (gfapi: Closed the logfile fd in glfs_fini) posted (#1) for review on master by poornima g (pgurusid)

Comment 2 Anand Avati 2013-12-20 17:55:00 UTC
REVIEW: http://review.gluster.org/6551 (gfapi: Closed the logfile fd and initialize to NULL in glfs_fini) posted (#1) for review on master by poornima g (pgurusid)

Comment 3 Anand Avati 2013-12-20 18:20:49 UTC
REVIEW: http://review.gluster.org/6552 (gfapi: Closed the logfile fd and initialize to NULL in glfs_fini) posted (#1) for review on master by poornima g (pgurusid)

Comment 4 Anand Avati 2013-12-23 12:18:32 UTC
REVIEW: http://review.gluster.org/6552 (gfapi: Closed the logfile fd and initialize to NULL in glfs_fini) posted (#2) for review on master by poornima g (pgurusid)

Comment 5 Anand Avati 2013-12-23 12:55:51 UTC
REVIEW: http://review.gluster.org/6552 (gfapi: Closed the logfile fd and initialize to NULL in glfs_fini) posted (#3) for review on master by poornima g (pgurusid)

Comment 6 Anand Avati 2013-12-24 02:23:07 UTC
REVIEW: http://review.gluster.org/6552 (gfapi: Closed the logfile fd and initialize to NULL in glfs_fini) posted (#4) for review on master by poornima g (pgurusid)

Comment 7 Anand Avati 2013-12-26 11:16:39 UTC
COMMIT: http://review.gluster.org/6552 committed in master by Vijay Bellur (vbellur) 
------
commit 0d7279d32d5f55c0210bdcfda2d3f83e35f524b6
Author: Poornima G <pgurusid>
Date:   Mon Dec 23 05:11:15 2013 +0000

    gfapi: Closed the logfile fd and initialize to NULL in glfs_fini
    
    Currently if logfile is closed and other threads call gf_log
    after glfs_fini() is executed, it may lead to memory corruption.
    Adding gf_log_fini() which closes the logfile and initializes
    the logfile to NULL, thus any further logging happens to stderr.
    Also added gf_log_globals_fini() which should be filled in the
    future to release all the logging resources.
    
    Change-Id: I879163e1a3636e65300d166f782517ee773cab65
    BUG: 1030228
    Signed-off-by: Poornima G <pgurusid>
    Reviewed-on: http://review.gluster.org/6552
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 8 Anand Avati 2014-01-20 06:54:03 UTC
REVIEW: http://review.gluster.org/6731 (gfapi: Closed the logfile fd and initialize to NULL in glfs_fini) posted (#1) for review on release-3.5 by poornima g (pgurusid)

Comment 9 Anand Avati 2014-01-21 04:22:56 UTC
COMMIT: http://review.gluster.org/6731 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit ca7586841e507305ebb951d604c077cf8de84920
Author: Poornima G <pgurusid>
Date:   Mon Dec 23 05:11:15 2013 +0000

    gfapi: Closed the logfile fd and initialize to NULL in glfs_fini
    
    Backport of http://review.gluster.org/6552
    
    Currently if logfile is closed and other threads call gf_log
    after glfs_fini() is executed, it may lead to memory corruption.
    Adding gf_log_fini() which closes the logfile and initializes
    the logfile to NULL, thus any further logging happens to stderr.
    Also added gf_log_globals_fini() which should be filled in the
    future to release all the logging resources.
    
    BUG: 1030228
    Change-Id: I90f7fb744b05bc6bd14c61fe143c0814896991e2
    Signed-off-by: Poornima G <pgurusid>
    Reviewed-on: http://review.gluster.org/6552
    Reviewed-on: http://review.gluster.org/6731
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 10 Niels de Vos 2014-04-17 11:50:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.