Bug 1031787 - LMI_DirectoryContainsFileProvider.c crash if called with a non-directory
Summary: LMI_DirectoryContainsFileProvider.c crash if called with a non-directory
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: openlmi-providers
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Synacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-18 18:36 UTC by Klaus Kämpf
Modified: 2013-11-19 07:52 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-19 07:52:41 UTC
Type: Bug

Attachments (Terms of Use)
Check return value of opendir() and return proper status (955 bytes, patch)
2013-11-18 18:36 UTC, Klaus Kämpf 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Klaus Kämpf 2013-11-18 18:36:20 UTC 
Created attachment 825780 [details]
Check return value of opendir() and return proper status

Description of problem:
If the Name property points to a non-directory, LMI_DirectoryContainsFileProvider.c crashes with a NULL pointer exception.

This is caused by opendir() returning error (NULL) but this value is used unchecked.

Fix attached.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Jan Safranek 2013-11-19 07:52:41 UTC 
Thanks for the patch! I pushed it to 0.4-fixes and master branches and it will be available in next OpenLMI release.
Note You need to log in before you can comment on or make changes to this bug.