Bug 1031993 - Block SD/DC creation with a proper message when using special characters.
Summary: Block SD/DC creation with a proper message when using special characters.
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-hosted-engine-setup
Version: unspecified
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: 3.3.0
Assignee: Alex Lourie
QA Contact: Leonid Natapov
URL:
Whiteboard: integration
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-19 10:24 UTC by Leonid Natapov
Modified: 2013-12-04 07:57 UTC (History)
7 users (show)

Fixed In Version: ovirt-hosted-engine-setup-1.0.0-0.10.1.rc.el6ev
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-04 07:57:17 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:0083 0 normal SHIPPED_LIVE new package: ovirt-hosted-engine-setup 2014-01-21 21:42:22 UTC
oVirt gerrit 21775 0 None None None Never
oVirt gerrit 21938 0 None None None Never

Description Leonid Natapov 2013-11-19 10:24:53 UTC
We should not allow enter special characters in the hosted engine setup values like DC and SD. Now,user can enter DC name like *&^%$#@ which is forbidden if user were using UI. Hosted engine setup should align with the UI.

Comment 1 Leonid Natapov 2013-11-19 10:26:23 UTC
The UI accepts the following:
---
Name can be only 'A-Z','a-z',0-9','-' or '_' characters
---

Comment 2 Martin Sivák 2013-11-19 11:14:41 UTC
Also make sure the smtp configuration for notifications obeys the standard rules:

SMTP server: ietf.org/rfc/rfc2181.txt section 11
EMAIL address: the regexp here is not simple.. but for example msivak+tag is a valid address :)

Comment 3 Sandro Bonazzola 2013-11-20 12:16:00 UTC
(In reply to Martin Sivák from comment #2)
> Also make sure the smtp configuration for notifications obeys the standard
> rules:
> 
> SMTP server: ietf.org/rfc/rfc2181.txt section 11
> EMAIL address: the regexp here is not simple.. but for example
> msivak+tag is a valid address :)

This is already in, fixing bug #1032467.

Comment 4 Sandro Bonazzola 2013-12-03 09:00:49 UTC
patch merged on upstream master and 1.0 branches.

Comment 6 yeylon@redhat.com 2013-12-04 07:57:17 UTC
This bug was fixed and is slated to be in the upcoming version. As we
are focusing our testing at this phase on severe bugs, this bug was
closed without going through its verification step. If you think this
bug should be verified by QE, please set its severity to high and move
it back to ON_QA


Note You need to log in before you can comment on or make changes to this bug.