Bug 1032189 - improper use of gettext
Summary: improper use of gettext
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Pulp
Classification: Retired
Component: user-experience
Version: Master
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
: 2.4.0
Assignee: Michael Hrivnak
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-19 17:01 UTC by Michael Hrivnak
Modified: 2014-08-09 06:57 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-09 06:57:06 UTC
Embargoed:


Attachments (Terms of Use)
xgettext output (3.60 KB, text/plain)
2013-11-19 17:01 UTC, Michael Hrivnak
no flags Details

Description Michael Hrivnak 2013-11-19 17:01:04 UTC
Created attachment 826212 [details]
xgettext output

There are numerous cases where we are calling gettext with positional string substitution, which does not work. We must always use name-based substitution in case a translate needs to change the word order.

The attached output is for the platform only. "xgettext" should be run in pulp_rpm and pulp_puppet as well, where I suspect more errors will be found.

Comment 2 Jeff Ortel 2014-04-03 13:36:31 UTC
build: 2.4.0-0.7.beta

Comment 3 Michael Hrivnak 2014-07-03 19:29:00 UTC
This can be verified by running the same two commands shown at the top of the attachment, and making sure the list of warnings is shorter than the list in the attachment.

Comment 4 Preethi Thomas 2014-07-06 10:22:34 UTC
verified
[root@yttrium ~]# rpm -qa pulp-server
pulp-server-2.4.0-0.23.beta.el6.noarch
[root@yttrium ~]# 
[root@yttrium ~]# find . -name *.py > source_files.txt
[root@yttrium ~]# xgettext -f source_files.txt -o catalog.pot
[root@yttrium ~]#

Comment 5 Randy Barlow 2014-08-09 06:57:06 UTC
This has been fixed in Pulp 2.4.0-1.


Note You need to log in before you can comment on or make changes to this bug.