Bug 1033403 - Wrong notification shown for settings update after removing a language
Summary: Wrong notification shown for settings update after removing a language
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Zanata
Classification: Retired
Component: Component-UI
Version: development
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.2
Assignee: Alex Eng
QA Contact: Damian Jansen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-22 03:34 UTC by Damian Jansen
Modified: 2014-02-18 06:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-02-18 06:48:28 UTC


Attachments (Terms of Use)
Screenshot (67.14 KB, image/png)
2013-11-25 03:59 UTC, Damian Jansen
no flags Details

Description Damian Jansen 2013-11-22 03:34:12 UTC
Description of problem:
If the group maintainer removes a language, then updates some general settings, the success notification shown for updating the settings is the "Language x has been removed from the group"

Version-Release number of selected component (if applicable):
dev

How reproducible:
Moderate, always

Steps to Reproduce:
1. Sign in as admin, go to Groups
2. Select / Create a group
3. If the group has no set languages, add one (Click settings, languages, Add)
4. In Settings -> Languages, remove a group
5. Go to Settings -> General
6. Press Update general settings

Actual results:
Notification: "Language 'French' has been removed from group."

Expected results:
Notification: "Successfully updated"

Additional info:
It seems the correct notification is shown, but only for a fraction of a second before showing the wrong one

Comment 3 Alex Eng 2013-11-24 22:04:22 UTC
The expected results when add/removing locale should be:
"Language 'French' has been add/removed from group."

"Successfully updated" is a generic message return from server when entity is updated.

Comment 4 Damian Jansen 2013-11-25 03:59:26 UTC
Created attachment 828499 [details]
Screenshot

Is this a valid notification scenario?

i.e. I removed the language French, then renamed the group. The Add/Remove notification didn't go away.

Comment 5 Alex Eng 2013-11-25 04:52:28 UTC
Pull request:
https://github.com/zanata/zanata-server/pull/294

Comment 6 Damian Jansen 2013-11-26 03:10:14 UTC
Verified at 19c23e1a933e97cb309638a92053d139f26fedd0


Note You need to log in before you can comment on or make changes to this bug.