Bug 1033419 - Group languages check does not respect the server defaults (no project overrides)
Summary: Group languages check does not respect the server defaults (no project overri...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Zanata
Classification: Retired
Component: Component-Logic
Version: development
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 3.2
Assignee: Alex Eng
QA Contact: Damian Jansen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-22 04:32 UTC by Damian Jansen
Modified: 2014-02-18 06:48 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2014-02-18 06:48:21 UTC


Attachments (Terms of Use)
Test run log file (58.62 KB, text/x-log)
2013-11-25 02:15 UTC, Damian Jansen
no flags Details

Description Damian Jansen 2013-11-22 04:32:10 UTC
Description of problem:
If:
- a project has not selected to override the server languages (no custom list)
- the server has a language that is not enabled by default,
- the group has added this language

then the project version will show in the group's page with no given warnings, and can attempt to open the document and results in presenting an error to the user.

Version-Release number of selected component (if applicable):
dev

How reproducible:
Moderate, seems always

Steps to Reproduce:
1. Log in as admin, go to Sidebar menu -> Administration -> Manage Languages
   - Ensure there is, in the set of languages shown, one with an unchecked "Enabled" checkbox (ie. disabled by default)

2. Go to Groups, select or create a new group
3. Go to Settings -> Languages
4. Add the "disabled by default" language

5. Go to projects and either
   - create a basic, all defaults project (no overrides)
   - alter an existing one to remove the overrides
6. Add a source document to the project version if none exist

7. Go back to Groups -> the created group
8. Go to Settings -> Projects
9. Add the project version as was created/altered above
10. Click languages
   - See the disabled language is there, but with no warnings
11. Click the language so that it shows the project in the sidebar
12. Click the project name
   - See that it proceeds to a document list
13. Click the document

Actual results:
22/11/13 14:30:34 Failed to load data from server

Expected results:
Should never have got this far - the group page should recognised the disabled by default language and presented an error.

Additional info:
My fingers hurt after typing this bug.

Comment 1 Alex Eng 2013-11-22 04:53:33 UTC
Additional to this bug:
We might need to disabled the link to editor if the locale is missing from the project.

Comment 3 Damian Jansen 2013-11-25 02:15:00 UTC
The fix has created a new bug, where a language selected immediately after being added causes an exception.

Comment 4 Damian Jansen 2013-11-25 02:15:23 UTC
Created attachment 828467 [details]
Test run log file

Comment 5 Alex Eng 2013-11-25 02:38:03 UTC
As in github, @Damian Jansen please retest this.

Comment 6 Damian Jansen 2013-11-25 03:22:46 UTC
Verified at 2a815b3473d0d4294434e5756bcb7888a8b33d9d


Note You need to log in before you can comment on or make changes to this bug.