Bug 1033571 - nettle: use size_t for sizes, protect computations
Summary: nettle: use size_t for sizes, protect computations
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: nettle
Version: 7.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Nikos Mavrogiannopoulos
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On:
Blocks: 1033527
TreeView+ depends on / blocked
 
Reported: 2013-11-22 12:06 UTC by Florian Weimer
Modified: 2013-12-13 16:01 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-13 16:01:59 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Florian Weimer 2013-11-22 12:06:27 UTC
buffer.h uses unsigned values for keeping track of allocated sizes.  This means that a call to nettle_buffer_grow could silently truncate a large argument of type size_t (on 64 bit systems), for example.

This issue also applies to nettle_realloc_func 

Furthermore, a size computation in nettle_buffer_grow can wrap around, failing to allocate additional buffer space:

  if (buffer->size + length > buffer->alloc)

There is another size computation in asn1_der_get_bignum which looks a bit suspicious as well.  If 8 * i->length wraps around, then the max_bits restriction is not necessarily enforced:

  if (max_bits && (8 * i->length > (16 + max_bits)))

This size computation in pgp_armor needs a guard against wraparound, too:

      unsigned text_size = BASE64_ENCODE_LENGTH(length)
	+ BASE64_ENCODE_FINAL_LENGTH;

Comment 2 Nikos Mavrogiannopoulos 2013-12-11 11:31:17 UTC
This is fixed in nettle's master branch, at the cost of an ABI change. I don't think there is much we can do on that (except maintaining a local version of nettle). Nevertheless, I think the impact is minimal as I don't see the nettle's buffer.h to be used in the projects using nettle.


Note You need to log in before you can comment on or make changes to this bug.