Bug 1034003 - xfstests xfs/216: mkfs.xfs log size scaling test failed
Summary: xfstests xfs/216: mkfs.xfs log size scaling test failed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: xfsprogs
Version: 7.0
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Eric Sandeen
QA Contact: Boris Ranto
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-11-25 03:11 UTC by Eryu Guan
Modified: 2014-06-18 04:55 UTC (History)
1 user (show)

Fixed In Version: xfsprogs-3.2.0-0.8.alpha2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 12:52:49 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Eryu Guan 2013-11-25 03:11:23 UTC
Description of problem:
Not sure if it's really an xfsprogs bug, but xfs/216 fails with xfsprogs-3.2.0-0.1.alpha1.el7 now

=== full diff out/out.bad ===
--- /dev/fd/63	2013-11-15 08:38:10.075626886 -0500
+++ results/xfs/216.out.bad	2013-11-15 08:38:08.003739617 -0500
@@ -1,10 +1,10 @@
 QA output created by 216
-fssize=1g log      =internal log           bsize=4096   blocks=2560, version=2
-fssize=2g log      =internal log           bsize=4096   blocks=2560, version=2
-fssize=4g log      =internal log           bsize=4096   blocks=2560, version=2
-fssize=8g log      =internal log           bsize=4096   blocks=2560, version=2
-fssize=16g log      =internal log           bsize=4096   blocks=2560, version=2
-fssize=32g log      =internal log           bsize=4096   blocks=4096, version=2
-fssize=64g log      =internal log           bsize=4096   blocks=8192, version=2
+fssize=1g log      =internal log           bsize=4096   blocks=12800, version=2
+fssize=2g log      =internal log           bsize=4096   blocks=12800, version=2
+fssize=4g log      =internal log           bsize=4096   blocks=12800, version=2
+fssize=8g log      =internal log           bsize=4096   blocks=12800, version=2
+fssize=16g log      =internal log           bsize=4096   blocks=12800, version=2
+fssize=32g log      =internal log           bsize=4096   blocks=12800, version=2
+fssize=64g log      =internal log           bsize=4096   blocks=12800, version=2
 fssize=128g log      =internal log           bsize=4096   blocks=16384, version=2
 fssize=256g log      =internal log           bsize=4096   blocks=32768, version=2

Version-Release number of selected component (if applicable):
xfsprogs-3.2.0-0.1.alpha1.el7

How reproducible:
always

Steps to Reproduce:
1. check xfs/216 on xfs
2.
3.

Actual results:
test fails

Expected results:
test passes

Additional info:

Comment 1 Eric Sandeen 2014-02-21 19:24:31 UTC
Log scaling changed with:

commit 88cd79be1aa1f6947d20da102fbf5bb128d70ce1
Author: Dave Chinner <dchinner>
Date:   Wed Sep 4 22:05:50 2013 +0000

    xfs: Add xfs_log_rlimit.c
    
    Add source files for xfs_log_rlimit.c The new file is used for log
    size calculations and validation shared with userspace.
    
    [dchinner: xfs_log_calc_max_attrsetm_res() does not modify the
    tr_attrsetm reservation, just calculates the maximum. ]
    
    [dchinner: rework loop in xfs_log_get_max_trans_res() ]
    
    [dchinner: implement xfs_log_calc_unit_res() in util.c to give mkfs
    a worse case calculation of the log size needed. ]
    
    Signed-off-by: Jie Liu <jeff.liu>
    Signed-off-by: Dave Chinner <dchinner>
    Reviewed-by: Mark Tinguely <tinguely>
    Signed-off-by: Rich Johnston <rjohnston>


Let me see if it was intentional...

Comment 2 Eric Sandeen 2014-02-26 02:22:58 UTC
Ok, Dave has a patch on the list to fix this:

  [PATCH] mkfs: default log size for small filesystems too large

but it needs a V2.

Setting blocker? & marking as a regression, this is an unintentional change from the CRC updates.

Comment 4 Boris Ranto 2014-03-04 09:42:02 UTC
Verified in xfsprogs-3.2.0-0.8.alpha2.el7, the log size is of the same size that the test case expects it to be.

Reproduced in xfsprogs-3.2.0-0.6.alpha2.el7, the log size is too big on sub-64g file systems.

Comment 5 Ludek Smid 2014-06-13 12:52:49 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.