Bug 1034869 - satyr: strbuf should measure lengths in size_t
Summary: satyr: strbuf should measure lengths in size_t
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: satyr
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Martin Milata
QA Contact: Lukáš Zachar
URL:
Whiteboard:
Depends On:
Blocks: 1034859
TreeView+ depends on / blocked
 
Reported: 2013-11-26 16:00 UTC by Florian Weimer
Modified: 2019-03-06 00:40 UTC (History)
2 users (show)

Fixed In Version: satyr-0.9-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-13 11:18:02 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Florian Weimer 2013-11-26 16:00:39 UTC 
Using size_t instead of int avoids truncation issues and makes detecting wraparound easier (because signed overflow is undefined).

sr_strbuf_grow() should perform overflow/wraparound checks.
Comment 2 Martin Milata 2013-11-26 21:31:48 UTC 
Thanks for the report. What do you think of the proposed solution: https://github.com/abrt/satyr/pull/136/files ?
Comment 5 Ludek Smid 2014-06-13 11:18:02 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.
Note You need to log in before you can comment on or make changes to this bug.